Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vega: Remove plot_ prefix. #64

Merged
merged 1 commit into from
Jun 20, 2022
Merged

vega: Remove plot_ prefix. #64

merged 1 commit into from
Jun 20, 2022

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Jun 20, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2022

Codecov Report

Merging #64 (7de079d) into main (5bfd273) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   97.16%   97.14%   -0.02%     
==========================================
  Files          16       16              
  Lines         493      491       -2     
  Branches       78       77       -1     
==========================================
- Hits          479      477       -2     
  Misses          8        8              
  Partials        6        6              
Impacted Files Coverage Δ
src/dvc_render/vega.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bfd273...7de079d. Read the comment docs.

@pared
Copy link
Contributor

pared commented Jun 20, 2022

Related to #61. We are removing the plot_ prefix from Renderer name. TableRenderer will not create plot, and there was never an actual reason to prefix the name like that.

@daavoo daavoo merged commit f08fa96 into main Jun 20, 2022
@daavoo daavoo deleted the remove-prefix branch June 20, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants