Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TableRenderer. #61

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Add TableRenderer. #61

merged 2 commits into from
Jun 17, 2022

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Jun 14, 2022

Make tabulate optional dependency.
Add table styles in PAGE_HTML.
Remove with_metrics method from HTML.

@daavoo daavoo requested a review from pared June 14, 2022 10:34
@daavoo daavoo linked an issue Jun 14, 2022 that may be closed by this pull request
@daavoo daavoo force-pushed the table-renderer branch 4 times, most recently from 83372d3 to d00b696 Compare June 15, 2022 11:24
Comment on lines +66 to +69
[[tool.mypy.overrides]]
module = "tabulate"
ignore_missing_imports = true

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's types-tabulate package that you can install.

@daavoo daavoo force-pushed the table-renderer branch 2 times, most recently from 619be98 to 2cdb53c Compare June 15, 2022 14:28
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #61 (538a106) into main (2698df5) will increase coverage by 1.32%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   95.83%   97.16%   +1.32%     
==========================================
  Files          14       16       +2     
  Lines         480      493      +13     
  Branches       78       78              
==========================================
+ Hits          460      479      +19     
+ Misses         15        8       -7     
- Partials        5        6       +1     
Impacted Files Coverage Δ
src/dvc_render/base.py 100.00% <ø> (ø)
src/dvc_render/html.py 84.00% <ø> (+13.03%) ⬆️
tests/test_html.py 100.00% <ø> (ø)
tests/test_parallel_coordinates.py 100.00% <ø> (ø)
src/dvc_render/table.py 73.33% <73.33%> (ø)
src/dvc_render/vega.py 100.00% <100.00%> (ø)
tests/test_table.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2698df5...538a106. Read the comment docs.

Make `tabulate` optional dependency.
Add table styles in `PAGE_HTML`.
Remove `with_metrics` method from HTML.
@daavoo daavoo merged commit ce75208 into main Jun 17, 2022
@pared pared mentioned this pull request Jun 20, 2022
@daavoo daavoo mentioned this pull request Jul 7, 2022
@daavoo daavoo deleted the table-renderer branch July 7, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new TableRenderer for metrics.
4 participants