Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cml-pr command #510

Merged
merged 62 commits into from
May 18, 2021
Merged

cml-pr command #510

merged 62 commits into from
May 18, 2021

Conversation

DavidGOrtega
Copy link
Contributor

@DavidGOrtega DavidGOrtega commented May 11, 2021 •
edited
Loading 

Usage: cml-pr.js <glob path> ... <glob path>

      Options:
        --version         Show version number                                [boolean]
        --md              Output in markdown format [](url).                 [boolean]
        --repo            Specifies the repo to be used. If not specified is extracted
                          from the CI ENV.
        --token           Personal access token to be used. If not specified in
                          extracted from ENV repo_token.
        --driver          If not specify it infers it from the ENV.
                                                         [choices: "github", "gitlab"]
        -h                Show help                                          [boolean]
        --git-remote                                               [default: "origin"]
        --git-user-email                              [default: "olivaw@iterative.ai"]
        --git-user-name                                  [default: "iterative-olivaw"]

closes #474

casperdcl
casperdcl suggested changes May 17, 2021
View reviewed changes
bin/cml-pr.js Outdated Show resolved Hide resolved
src/cml.js Outdated Show resolved Hide resolved
src/cml.js Show resolved Hide resolved
@casperdcl casperdcl mentioned this pull request May 17, 2021
Closed
1 task
@DavidGOrtega
Copy link
Contributor Author

@casperdcl 🙏 review feedback

@DavidGOrtega DavidGOrtega temporarily deployed to test-internal May 17, 2021 22:04 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to test-internal May 17, 2021 23:02 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to test-internal May 17, 2021 23:28 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to test-internal May 17, 2021 23:34 Inactive
@DavidGOrtega
Copy link
Contributor Author

@casperdcl hopefully ready

@DavidGOrtega DavidGOrtega temporarily deployed to test-internal May 18, 2021 06:25 Inactive
casperdcl
casperdcl approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, important stuff (API) is fine, can iterate on minor things later

@0x2b3bfa0
Copy link
Member

About API: is cml-pr a good name for a command that provides an abstraction over GitHub Pull Requests and GitLab Merge Requests?

@casperdcl
Copy link
Contributor

@0x2b3bfa0 we can alias (later)? I don't have a better unifying name suggestion.

0x2b3bfa0
0x2b3bfa0 approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Implicit approval)

@DavidGOrtega DavidGOrtega changed the base branch from master to release/v0.4.0 May 18, 2021 23:39
@DavidGOrtega DavidGOrtega merged commit f130df4 into release/v0.4.0 May 18, 2021
@DavidGOrtega DavidGOrtega deleted the cml-pr branch May 18, 2021 23:39
@DavidGOrtega DavidGOrtega mentioned this pull request May 18, 2021
Merged
DavidGOrtega added a commit that referenced this pull request May 19, 2021
@DavidGOrtega @0x2b3bfa0 @casperdcl
Release v0.4.0 (#523) (#519) (#516) (#534) (#510) (#517) (#535)
d716d30 
* No await runner (#523)

* cml-publish mime and repo (#519)

* cml-publish mime and repo

* cleanup

* image/svg+xml

* buffer

* resolve

* text buffer outputs plain

* native bolean

* snapshot

* Fix pipe reading logic on Windows (#516)

The fs.readSync function throws EOF instead of returning 0 like in other systems.
See nodejs/node#35997 for more information.

* minor doc fixes (#534)

* cml-pr command (#510)

* test-cml-pr

* packages

* pre-release

* log isci

* log isci

* user_name

* log gitlab url

* log gitlab url

* short 8

* len paths

* no undef

* git

* files

* files

* files

* files

* files

* files

* files

* files

* files

* files

* files

* files

* files

* files

* files

* files

* files

* sha2

* sha2

* log filepath

* log filepath

* log filepath

* exists and  clean

* SHA vs SHA2

* pre-release

* pre-release 2

* pre-release 3

* pre-release 3

* pre-release 3

* pre-release 3

* pre-release 3

* pre-release 3

* git back

* git back

* git back

* release

* REPO_TOKEN

* html_url

* cml pr defaults

* cml pr defaults

* test strict again

* CI

* vars

* shorter params

* snapshots and olivaw

* test david

* BB fix

* snapshots

* No git sha dependencies (#517)

* check head_sha

* 0.4.0

Co-authored-by: Helio Machado <0x2b3bfa0+git@googlemail.com>
Co-authored-by: Casper da Costa-Luis <work@cdcl.ml>
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request May 19, 2021
Closed
@DavidGOrtega
Copy link
Contributor Author

@0x2b3bfa0

About API: is cml-pr a good name for a command that provides an abstraction over GitHub Pull Requests and GitLab Merge Requests?

To be fair also bitbucket and in Bitbucket is PR also. Additionally we have at least in the markdown taken that consideration. Pull for GHBB and Merge for GL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

@casperdcl casperdcl casperdcl approved these changes

Assignees

@DavidGOrtega DavidGOrtega

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cml-pr specs and prototype
3 participants
@DavidGOrtega @0x2b3bfa0 @casperdcl