Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cml-pr: follow-up #529

Closed
1 task
casperdcl opened this issue May 17, 2021 · 5 comments
Closed
1 task

cml-pr: follow-up #529

casperdcl opened this issue May 17, 2021 · 5 comments
Assignees
Labels
technical-debt Refactoring, linting & tidying

Comments

@casperdcl
Copy link
Contributor

casperdcl commented May 17, 2021

Follow-up to #510

@casperdcl casperdcl added the technical-debt Refactoring, linting & tidying label May 17, 2021
@DavidGOrtega
Copy link
Contributor

@0x2b3bfa0 I think both are supported

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Jun 1, 2021

Yes, it's mostly a documentation choice and, to a lesser extent, a design decision: I would even consider providing a mechanism to enable or disable globs like in dvc add

@0x2b3bfa0
Copy link
Member

It's me, or cml-pr would be a lot more useful if pull request titles, pull request messages and commit messages were configurable; or, at least, if there was an option to disable the skip-ci text? See this discuss.dvc.org thread for an example.

@dacbd
Copy link
Contributor

dacbd commented May 12, 2022

Stale / done?

@dacbd dacbd closed this as completed May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical-debt Refactoring, linting & tidying
Projects
None yet
Development

No branches or pull requests

4 participants