Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/#110 windows ci issue fixing part 2 #112

Merged
merged 8 commits into from
Oct 19, 2024
Merged

Bugfix/#110 windows ci issue fixing part 2 #112

merged 8 commits into from
Oct 19, 2024

Conversation

maythamfahmi
Copy link
Collaborator

  • Windows pipeline fixed
  • Refactoring
  • Clean up

@maythamfahmi maythamfahmi added the version3.0.0-preview001 CryptoNet Version 3 label Oct 19, 2024
@maythamfahmi maythamfahmi self-assigned this Oct 19, 2024
masterpeter2720
masterpeter2720 approved these changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@masterpeter2720 masterpeter2720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved based on It pass windows ci and no code comments.

ubuntu, macos is still down as I can see there are bug issue #107 for that as well as code coverage #108

@maythamfahmi maythamfahmi merged commit 19afd6a into version3 Oct 19, 2024
4 of 7 checks passed
@maythamfahmi maythamfahmi mentioned this pull request Oct 19, 2024
Closed
1 task
@maythamfahmi maythamfahmi deleted the bugfix/#110-windows-ci-issue-fixing-part-2 branch October 20, 2024 05:37
maythamfahmi added a commit that referenced this pull request Nov 3, 2024
@maythamfahmi @jwdonahue
Version3 (#125)
8adf313 
#84 
#85 
#86
#87
#96
#97 
#100
#101
#103
#104
#106
#107
#110
#111
#112 
#113
#114
#115
#120
#122

Authored-by: Maytham Fahmi <maythamfahmi@hotmail.com>
Co-authored-by: Joseph Donahue <joseph@odonahue.com>
Co-authored-by: Joseph W Donahue <joseph@sharperhacksllc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterpeter2720 masterpeter2720 masterpeter2720 approved these changes

@Memhave Memhave Awaiting requested review from Memhave

@jwdonahue jwdonahue Awaiting requested review from jwdonahue

Assignees

@maythamfahmi maythamfahmi

Labels
version3.0.0-preview001 CryptoNet Version 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maythamfahmi @masterpeter2720