Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]: Test coverage need to reach higher rate than today 70% #86

Closed
1 task done
maythamfahmi opened this issue Oct 17, 2024 · 4 comments
Closed
1 task done
Assignees
Labels
enhancement New feature or request version3.0.0-preview001 CryptoNet Version 3

Comments

@maythamfahmi
Copy link
Collaborator

maythamfahmi commented Oct 17, 2024

Contact Details

No response

Is your feature request related to a problem? Please describe.

not directly

Describe the solution you'd like

We want to imporve test coverage. Today it is aroud 70%, every thing 80% and up would be cool to reach.

Our ulitmate goal is to reach 100%.

Describe alternatives you've considered

No response

Additional context

No response

Priority Level

Low

Code of Conduct

  • I agree to follow this project's Code of Conduct
@maythamfahmi maythamfahmi added the enhancement New feature or request label Oct 17, 2024
@maythamfahmi maythamfahmi added the version3.0.0-preview001 CryptoNet Version 3 label Oct 17, 2024
@maythamfahmi
Copy link
Collaborator Author

maythamfahmi commented Oct 19, 2024

with all new tests introduces we are already at above 80%, I think for this stage it is fine so far. I think few more test for extensions method and the todo mentioned in the code for RSA, I will look at it hopefully we can hit 90%

image

@maythamfahmi maythamfahmi self-assigned this Oct 19, 2024
@jwdonahue
Copy link
Collaborator

I am generally not happy with anything less than 100%, except for the few occasional code paths that are more costly to cover, than expert review. Those are rare, and usually involve impossible corner-cases/code paths that are their purely to make the compiler happy (ie; default cases in switch statements, or exceptional paths that should never be hit). Simple libraries should approach 100% coverage, but not at the expense of alternate path permutations through the code. Complete coverage != thorough testing.

I am pleased to see the improvement in coverage though.

@maythamfahmi
Copy link
Collaborator Author

I agree with you if we can do 100% that would be awesome.

maythamfahmi added a commit that referenced this issue Oct 20, 2024
maythamfahmi added a commit that referenced this issue Oct 20, 2024
maythamfahmi added a commit that referenced this issue Oct 20, 2024
maythamfahmi added a commit that referenced this issue Oct 20, 2024
maythamfahmi added a commit that referenced this issue Oct 20, 2024
maythamfahmi added a commit that referenced this issue Oct 20, 2024
maythamfahmi added a commit that referenced this issue Oct 20, 2024
maythamfahmi added a commit that referenced this issue Oct 20, 2024
* #86 remove unused code

* #86 adding unittest for DirectoryExensionTests

* #86 imporve check content

* #86 rename test class to share project and test check content

* #86 adding coverlet msbuild for code coverage test

* #86  gitingore encrypt file from test

* #86 test UniqueKeyGenerator

* #86 add exception to UniqueKeyGenerator

* #86 fix test

* #86 tmp allow test to check if it works

* #86 update editor config with 2 space for csproj

* #86 space intent

* #86 remove unnec tags from AES example csproj

* #86 temp ignore example test to check all tests for other os

* #86 remove old and dead cli from docker test

* #86 remove not wanted test

* #86 update text messge for ignore,
@maythamfahmi
Copy link
Collaborator Author

We are at 85%, this will be closed, and move to #123 list than the scope of testing will be expanded as smaller features until it reachs its ultimum goal :)

maythamfahmi added a commit that referenced this issue Nov 3, 2024
#84 
#85 
#86
#87
#96
#97 
#100
#101
#103
#104
#106
#107
#110
#111
#112 
#113
#114
#115
#120
#122

Authored-by: Maytham Fahmi <maythamfahmi@hotmail.com>
Co-authored-by: Joseph Donahue <joseph@odonahue.com>
Co-authored-by: Joseph W Donahue <joseph@sharperhacksllc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request version3.0.0-preview001 CryptoNet Version 3
Projects
None yet
Development

No branches or pull requests

2 participants