feat: added ISO18013 proximity flow #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: Defined terms and editorial on issuance introduction * Issuance: detailed flow up to the federation discovery * fix: issuance according to OpenID4VCI Draft 13 * fix!: issuance - credential_supported schema * fix: issuance - request object reordiering members * fix!: issuance - authorization_servers in the metadata - Closes #148 * chore: issuance - added proof_types_supported in the metadata * fix: issuance - metadata - proof types mandatory - according to https://github.com/openid/OpenID4VCI/pull/87/files * fix: remove NRA * editorials: OpenID Connect Core 1.0 or SAML2 * fix: WIA~POP removed from token endpoint * fix: WIA~POP removed from token endpoint * fix: credential_definition.type is an ARRAY * fix: editorial on vci metadata * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review with Amir Co-authored-by: asharif1990 <35602900+asharif1990@users.noreply.github.com> * fix!: alignments according to breaking changes introduced by openid4vci I-D * fix!: alignments according to breaking changes introduced by openid4vci I-D - ff * Apply suggestions from code review Co-authored-by: fmarino-ipzs <77629526+fmarino-ipzs@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: asharif1990 <35602900+asharif1990@users.noreply.github.com> Co-authored-by: fmarino-ipzs <77629526+fmarino-ipzs@users.noreply.github.com> --------- Co-authored-by: asharif1990 <35602900+asharif1990@users.noreply.github.com> Co-authored-by: fmarino-ipzs <77629526+fmarino-ipzs@users.noreply.github.com>
fmarino-ipzs
requested review from
balanza,
grausof,
peppelinux,
giadas and
asharif1990
|
@fmarino-ipzs I have rebased to get this merged to the branch rp just to get all the potential conflicts resolved asap |
peppelinux
requested changes
Jan 9, 2024
There was a problem hiding this comment.
@fmarino-ipzs just editorial, don't worry
I didn't had time to check each sinlge example in detail, we can do this later on
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
peppelinux
approved these changes
Jan 10, 2024
peppelinux
reviewed
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISO 18013 Proximity Flow (mDoc-CBOR)
Content
This PR closes #184
Added a subsection in the Replying Party Section.
Review