Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: OpenID4VCI Draft 13 #175

Merged
merged 24 commits into from
Jan 3, 2024
Merged

fix!: OpenID4VCI Draft 13 #175

merged 24 commits into from
Jan 3, 2024

Conversation

peppelinux
Copy link
Member

@peppelinux peppelinux commented Dec 12, 2023 •
edited
Loading

This PR:

The following PR https://github.com/italia/eudi-wallet-it-docs/pull/170/files included changes considered needed in this PR, however, having them in a separate PR these was not included in this PR. -> RAR schema changed in openid4vci.

This PR also anticipates this https://github.com/openid/OpenID4VCI/pull/87/files

asharif1990
asharif1990 suggested changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@asharif1990 asharif1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions to make some changes. Please have a look.

@asharif1990
Apply suggestions from code review with Amir
2737fbb 
Co-authored-by: asharif1990 <35602900+asharif1990@users.noreply.github.com>
@fmarino-ipzs
Apply suggestions from code review
bc5a170 
Co-authored-by: fmarino-ipzs <77629526+fmarino-ipzs@users.noreply.github.com>
asharif1990
asharif1990 suggested changes Dec 30, 2023
View reviewed changes
Copy link
Collaborator

@asharif1990 asharif1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor changes.

@asharif1990 @fmarino-ipzs
Apply suggestions from code review
3cecbe6 
Co-authored-by: asharif1990 <35602900+asharif1990@users.noreply.github.com>
Co-authored-by: fmarino-ipzs <77629526+fmarino-ipzs@users.noreply.github.com>
@peppelinux peppelinux merged commit 119cbad into versione-corrente Jan 3, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmarino-ipzs fmarino-ipzs fmarino-ipzs approved these changes

@asharif1990 asharif1990 asharif1990 approved these changes

@grausof grausof grausof approved these changes

@balanza balanza Awaiting requested review from balanza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@peppelinux @grausof @asharif1990 @fmarino-ipzs