Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade bsi to the latest version #309

Merged
merged 14 commits into from
Jan 22, 2024
Merged

Conversation

astagi
Copy link
Member

@astagi astagi commented Jan 15, 2024

Descrizione

Fixes #289

Checklist

Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-angular-kit ✅ Ready (Inspect) Visit Preview Jan 22, 2024 6:05pm

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (95ba0ef) 46.91% compared to head (0ebe1e2) 46.96%.

Files Patch % Lines
...onents/form/autocomplete/autocomplete.component.ts 36.00% 16 Missing ⚠️
...b/components/navigation/header/header.component.ts 30.76% 8 Missing and 1 partial ⚠️
...t/src/lib/components/form/input/input.component.ts 12.50% 7 Missing ⚠️
...nents/navigation/navbar/navbar/navbar.component.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
+ Coverage   46.91%   46.96%   +0.04%     
==========================================
  Files          77       81       +4     
  Lines        1151     1169      +18     
  Branches      239      242       +3     
==========================================
+ Hits          540      549       +9     
- Misses        588      596       +8     
- Partials       23       24       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astagi
Copy link
Member Author

astagi commented Jan 15, 2024

@AntoninoBonanno in questa PR ho aggiornato solo la dipendenza di Bootstrap Italia. Come puoi vedere dalla #289 ho già spuntato i componenti che non necessitano di modifiche (Avatar appena mergiamo la PR delle utils sarà sistemato).

Ci sono anche altri componenti che devono essere modificati ma che non sono stati creati, in quel caso possiamo spuntarli poi senza problemi e mergiare questo upgrade (in pratica mancherebbe solo da riguardare Header e Input per considerare questa PR completata).

@AntoninoBonanno
Copy link
Collaborator

@astagi ok domani sera sistemo il resto. Per i componenti mancanti facciamo delle PR dedicate, giusto?

@astagi
Copy link
Member Author

astagi commented Jan 15, 2024

@astagi ok domani sera sistemo il resto. Per i componenti mancanti facciamo delle PR dedicate, giusto?

@AntoninoBonanno si andrei di PR dedicate, grazie!

@AntoninoBonanno AntoninoBonanno marked this pull request as draft January 16, 2024 17:43
# Conflicts:
#	projects/design-angular-kit/src/lib/components/form/input/input.component.html
#	projects/design-angular-kit/src/lib/components/form/input/input.component.ts
@AntoninoBonanno
Copy link
Collaborator

@astagi mi sembra che tutte le breaking changes della v2.8.2 sono risolti.

Gli altri componenti elencati nell'issue non esistono sulla libreria (Tranne l'header ma ho controllato e per le parti che ci sono non bisogna modificare nulla)

quindi prima di chiudere questa PR completerei l'autocomplete su questa branch (#302 (comment))

@astagi astagi linked an issue Jan 18, 2024 that may be closed by this pull request
7 tasks
@astagi astagi removed a link to an issue Jan 18, 2024
7 tasks
@astagi astagi linked an issue Jan 18, 2024 that may be closed by this pull request
7 tasks
@astagi astagi force-pushed the feature/upgrade-bsi-2.8 branch from 32c4616 to 13ad966 Compare January 22, 2024 16:00
@astagi astagi marked this pull request as ready for review January 22, 2024 16:07
@astagi astagi merged commit ec5df3a into main Jan 22, 2024
5 of 6 checks passed
@astagi astagi deleted the feature/upgrade-bsi-2.8 branch January 23, 2024 22:49
Copy link
Contributor

🎉 This PR is included in version 0.14.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

🎉 This PR is included in version 1.0.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants