Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separare la funzionalità di autocomplete in un nuovo componente #302

Closed
AntoninoBonanno opened this issue Jan 14, 2024 · 5 comments · Fixed by #309
Closed

Separare la funzionalità di autocomplete in un nuovo componente #302

AntoninoBonanno opened this issue Jan 14, 2024 · 5 comments · Fixed by #309
Assignees
@astagi
Labels
enhancement New feature or request new component released on @prerelease released
Milestone
Version 1.0.0

Comments

@AntoninoBonanno
Copy link
Collaborator

Comportamento atteso

Sarebbe opportuno separare la logica dell'auto-completamento in un componente separato, ciò permette di mantenere meglio la funzionalità e non appesantire il componente it-input

Comportamento attuale

Attualmente il componente it-input include la funzionalità di autocomplete

Possibili soluzioni

Realizzare il componente it-autocomplete che si dedica solo a questa funzionalità.
@AntoninoBonanno AntoninoBonanno added enhancement New feature or request new component next Next version labels Jan 14, 2024
@astagi
Copy link
Member

astagi commented Jan 15, 2024

Concordo @AntoninoBonanno ! Posso prendermi in carico io questo task.

@astagi astagi self-assigned this Jan 15, 2024
@astagi astagi added this to the Version 1.0.0 milestone Jan 15, 2024
@astagi astagi removed the next Next version label Jan 15, 2024
AntoninoBonanno added a commit that referenced this issue Jan 16, 2024
@AntoninoBonanno
feat: split autocomple to another component
082ee93 
Refs: #302
@AntoninoBonanno
Copy link
Collaborator Author

@astagi per la PR #289 devo modificare il componente it-input quindi mi è venuto naturale splittare il componente.

trovi già it-autocomplete nella branch feature/upgrade-bsi-2.8, ma il componente non ricopre tutti i casi e va testato (mi sono limitato solo a spostare il codice ad hoc)

In particolare bisogna implementare i casi

AntoninoBonanno added a commit that referenced this issue Jan 16, 2024
@AntoninoBonanno
test(fix): fixed autocomplete test
9132ae9 
Refs: #302
AntoninoBonanno added a commit that referenced this issue Jan 16, 2024
@AntoninoBonanno
fix(autocomplete): fixed autocomplete imports
ccbe840 
Refs: #302
@AntoninoBonanno AntoninoBonanno mentioned this issue Jan 17, 2024
Merged
5 tasks
@AntoninoBonanno AntoninoBonanno linked a pull request Jan 20, 2024 that will close this issue
chore(deps): upgrade bsi to the latest version #309
Merged
5 tasks
AntoninoBonanno added a commit that referenced this issue Jan 20, 2024
@AntoninoBonanno
fix(autocomplete): added ability to show big autocomplete
9c75948 
Refs: #302
@astagi astagi closed this as completed in 9566deb Jan 22, 2024
github-actions bot pushed a commit that referenced this issue Jan 24, 2024
@semantic-release-bot
chore(release): 0.14.0-prerelease.1 🎉 [skip ci]
a82e32a 
# [0.14.0-prerelease.1](v0.13.0...v0.14.0-prerelease.1) (2024-01-24)

### Bug Fixes

* active label in input with browser autofill ([af8e01d](af8e01d))
* add further tests and docs ([0c2646a](0c2646a))
* add input param to LanguageSwitcherComponent ([bdb24e2](bdb24e2))
* align buttons during validation ([e9dbd11](e9dbd11))
* assert non null elements on notification component ([9950d98](9950d98))
* **autocomplete:** added ability to show big autocomplete ([9c75948](9c75948)), closes [#302](#302)
* **autocomplete:** fixed autocomplete imports ([ccbe840](ccbe840)), closes [#302](#302)
* avatar linting ([000238d](000238d))
* **avatar:** fixed router-link missing importation ([0bbb7cb](0bbb7cb))
* build ([7604e36](7604e36))
* build and range on firefox ([50cb1e1](50cb1e1))
* build compiler options for dependencies ([249ea32](249ea32))
* card in image carousel ([87f1f90](87f1f90))
* checkbox click fired twice ([6cf4b7f](6cf4b7f))
* class button with icon or progress ([794f8c2](794f8c2))
* dependencies vulnerability ([9a8f791](9a8f791))
* dropdown init using bootstrap ([56350ac](56350ac))
* duplicate image upload on upload file list component ([41a12f2](41a12f2))
* email input bad validation ([e28cd06](e28cd06))
* error page component impossibile nascondere codice errore ([bf3448b](bf3448b))
* examples code indentation ([aab8dcf](aab8dcf))
* fixed directive compile broken when using @input transform ([1b72e9e](1b72e9e))
* fixed input-group-text on input component when prependText content is dynamic ([19930c5](19930c5))
* fixed tsconfig path for library ([54ae4ef](54ae4ef))
* form input label ([2180ab5](2180ab5))
* hardcoded iconhref in icon component ([dff8a25](dff8a25))
* **i18n:** translations with lazy loading modules ([09315c4](09315c4))
* icon component class attribute ([7a80eee](7a80eee))
* improve a11y and margins on back button ([57b1c45](57b1c45))
* input component type date max value ([4363f2e](4363f2e))
* input label ([77bdeea](77bdeea))
* input label with browser autofill ([43f49cc](43f49cc))
* input max min controls ([698adfd](698adfd))
* input number editable when disabled ([364fac6](364fac6))
* input with icons ([4d39007](4d39007))
* invalid message for abstract form components ([34054f5](34054f5))
* italian tax code regex ([081f2f1](081f2f1))
* language switcher component ([1fc893a](1fc893a))
* link class changes ([e284f6b](e284f6b))
* mark all as touched on form components ([05f2d72](05f2d72))
* merge and form component change detection update ([dca43b9](dca43b9))
* merge fix ([4afaede](4afaede))
* minor fixes on upload file list and upload drag drop components ([f9f9f72](f9f9f72))
* numeric inputs ([a7b5a4f](a7b5a4f))
* optimization tab-component and docs ([ed17bba](ed17bba))
* optimized progress button and bar components ([b9f1454](b9f1454))
* peerDependencies on package.json library ([1be5517](1be5517))
* **pipes:** fixed the mark-matching-text pipe ([b482ff8](b482ff8))
* progress state in progress button component ([a83d30f](a83d30f))
* radio button name in form array or nested form group ([91e7681](91e7681))
* **radioButton:** added ability to set the radio name manually ([bbdc97e](bbdc97e))
* README.md ([2034537](2034537))
* remove not existing directive from avatar ([2d1220c](2d1220c))
* remove static id inside pagination component ([0d67dcc](0d67dcc))
* removed access specifier in input attributes ([5944025](5944025))
* removed unused ItAbstractComponent from header and navbar ([0ebe1e2](0ebe1e2))
* restore symbol for currency and percentage ([5d7682c](5d7682c))
* restored angular.json for icons and i18n translations to work ([58a579f](58a579f))
* run test ([39cc058](39cc058))
* set value on checkbox and forms generic types ([571f9b7](571f9b7))
* test ([8c5ac03](8c5ac03))
* test for standalone components ([7d438ec](7d438ec))
* **textarea:** added to set textarea as readonly ([409c411](409c411))
* use active label when input type is color ([c39f896](c39f896))
* use button instead of a for avatar dropdown ([3d0d492](3d0d492))
* use default lang for translate service ([d55262b](d55262b))
* validation methods in abstract form and upload dragdrop components ([d0b5ea6](d0b5ea6))
* various fix on back button ([2718c5c](2718c5c))
* visualizzazione icone bootstrap-italia in app demo ([7961380](7961380))
* website docs not found ([de5c8c7](de5c8c7))

### Features

* ability to filter autocomplete data on backend ([1398307](1398307))
* add ability to insert html label to checkbox and radiobutton ([a7545e0](a7545e0))
* add back to top component ([8ba1cfe](8ba1cfe))
* add checkbox ([e737388](e737388))
* add chip component ([7cb2778](7cb2778))
* add dimmer component ([54cd067](54cd067))
* add forward directive ([9f7da5e](9f7da5e))
* add list component ([2503fcd](2503fcd))
* add navbar ([13ad966](13ad966))
* add range component ([ee0170c](ee0170c))
* add sorting to table ([0f039f4](0f039f4))
* added ability to set max and min date value inside input component ([c2ec250](c2ec250))
* added autocomplete attribute on input and password input ([56a8427](56a8427))
* added iban validator ([24e58ad](24e58ad))
* added invalid form feedback on select component ([64eaf85](64eaf85))
* added modal options ([804498d](804498d)), closes [#268](#268)
* added steppers component ([1bfa3fe](1bfa3fe))
* added the ability to enter an initial configuration ([bb3f03b](bb3f03b))
* added the possibility to insert a default option and to insert the options directly from html in the select component ([7c77572](7c77572))
* added utils method to retrieve mime type from base64 string ([16b6002](16b6002))
* Aggiunto supporto ed esempio in documentazione per radio button in Reactive Form ([6196909](6196909))
* avatar component ([d030d59](d030d59))
* card component ([b0333ff](b0333ff))
* convert button component in button directive and remove loading button ([cd1fdfd](cd1fdfd))
* convert components to standalone ([af3fdf1](af3fdf1))
* disable the buttons in the steppers component ([aa3f3ab](aa3f3ab))
* dropdown-component add methods and events ([8eb2976](8eb2976))
* dynamic id for components with mandatory id ([fcff309](fcff309))
* enhance icon href with relative path ([4196b0d](4196b0d))
* error page component ([ed39a34](ed39a34))
* **fix:** fix alert-component init using bootstrap, add methods and events ([d728f4f](d728f4f))
* **i18n:** improve localization ([46fa9af](46fa9af))
* improve header component ([b2552b9](b2552b9))
* improved password input component and validator ([046a096](046a096))
* new components ([7f3cec0](7f3cec0))
* new version for angular 14 ([5ef7323](5ef7323))
* pagination with changer, jump to, text links, total number text and simple mode ([95f9767](95f9767))
* **pipes:** added date-ago pipe ([97b3aed](97b3aed))
* **pipes:** added duration pipe ([6beea0f](6beea0f))
* rating component ([5a27146](5a27146))
* removed required forroot importation to use default configuration ([e1a5a02](e1a5a02))
* render dropdown as link ([2d50b57](2d50b57))
* search auto complete ([f608d1a](f608d1a))
* select can assign object as a value ([ba1c65d](ba1c65d)), closes [#270](#270)
* split autocomple to another component ([082ee93](082ee93)), closes [#302](#302)
* standalone components import separation ([cbba4c0](cbba4c0))
* update bootstrap italia version ([2991fda](2991fda)), closes [#271](#271)
* update bootstrap italia version ([f2eb397](f2eb397))
* update bootstrap-italia version ([e5b58ad](e5b58ad))
* update bootstrap-italia version and remove bootstrap-italia.min.js from index.html ([3cd3125](3cd3125))
* update dependencies ([8b40b0d](8b40b0d))
* upgrade angular and bootstrap italia version ([2c9feae](2c9feae))
* upgrade bootstrap italia version ([91f5259](91f5259))
* **utils:** added date utils ([2b22506](2b22506))

### Performance Improvements

* breadcrumb, carousel, card, back button, checkbox, list, password input, radio, steppers, upload drag drop components ([8576da5](8576da5))
* **fix:** fix back-to-top-component init using bootstrap, add methods and events, fix popover ([78db693](78db693))
* **fix:** optimize and fix tab-component init using bootstrap ([5ba6339](5ba6339))
* **fix:** optimized notification component, fix notification icon and multiple dismiss bug ([627b106](627b106))
* improved all BooleanInput with angular transform function ([0956e52](0956e52))
* optimize collapse-component and accordion-component ([2d458a9](2d458a9))
* optimize dropdown-component, included changedectorref to abstract-component ([d54a8aa](d54a8aa))
* optimize modal-component ([ec18be1](ec18be1))
@github-actions GitHub Actions
Copy link
Contributor

🎉 This issue has been resolved in version 0.14.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Jan 25, 2024
@semantic-release-bot
chore(release): 1.0.0-prerelease.1 🎉 [skip ci]
2f44b79 
# [1.0.0-prerelease.1](v0.20.0...v1.0.0-prerelease.1) (2024-01-25)

### Bug Fixes

* **autocomplete:** added ability to show big autocomplete ([9c75948](9c75948)), closes [#302](#302)
* **autocomplete:** fixed autocomplete imports ([ccbe840](ccbe840)), closes [#302](#302)
* avatar linting ([000238d](000238d))
* **avatar:** fixed router-link missing importation ([0bbb7cb](0bbb7cb))
* card in image carousel ([87f1f90](87f1f90))
* fixed directive compile broken when using @input transform ([1b72e9e](1b72e9e))
* fixed input-group-text on input component when prependText content is dynamic ([19930c5](19930c5))
* fixed tsconfig path for library ([54ae4ef](54ae4ef))
* input with icons ([4d39007](4d39007))
* merge fix ([4afaede](4afaede))
* **pipes:** fixed the mark-matching-text pipe ([b482ff8](b482ff8))
* **radioButton:** added ability to set the radio name manually ([bbdc97e](bbdc97e))
* remove not existing directive from avatar ([2d1220c](2d1220c))
* removed unused ItAbstractComponent from header and navbar ([0ebe1e2](0ebe1e2))
* **textarea:** added to set textarea as readonly ([409c411](409c411))
* use button instead of a for avatar dropdown ([3d0d492](3d0d492))

### Features

* add navbar ([13ad966](13ad966))
* add sorting to table ([0f039f4](0f039f4))
* improve header component ([b2552b9](b2552b9))
* **pipes:** added date-ago pipe ([97b3aed](97b3aed))
* **pipes:** added duration pipe ([6beea0f](6beea0f))
* split autocomple to another component ([082ee93](082ee93)), closes [#302](#302)
* **upgrade-major:** fixed prerelease versioning ([fe3781d](fe3781d))
* **utils:** added date utils ([2b22506](2b22506))

### Performance Improvements

* improved all BooleanInput with angular transform function ([0956e52](0956e52))
@github-actions GitHub Actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Mar 18, 2024
@semantic-release-bot
chore(release): 1.0.0 🎉 [skip ci]
fbaf45d 
# [1.0.0](v0.20.0...v1.0.0) (2024-03-18)

### Bug Fixes

* **a11y:** wai aria label for icon component ([3bfe2b4](3bfe2b4))
* add nav mode for language switch ([af2159f](af2159f))
* autocomplete label ([c7271f0](c7271f0))
* **autocomplete:** added ability to show big autocomplete ([9c75948](9c75948)), closes [#302](#302)
* **autocomplete:** fixed autocomplete imports ([ccbe840](ccbe840)), closes [#302](#302)
* avatar linting ([000238d](000238d))
* **avatar:** fixed router-link missing importation ([0bbb7cb](0bbb7cb))
* card in image carousel ([87f1f90](87f1f90))
* **DateUtils:** fixed countDays function ([5b11cc6](5b11cc6))
* fixed directive compile broken when using @input transform ([1b72e9e](1b72e9e))
* fixed input-group-text on input component when prependText content is dynamic ([19930c5](19930c5))
* fixed tsconfig path for library ([54ae4ef](54ae4ef))
* form validation ([367bdd6](367bdd6))
* input with icons ([4d39007](4d39007))
* merge fix ([4afaede](4afaede))
* **pipes:** fixed the mark-matching-text pipe ([b482ff8](b482ff8))
* **radioButton:** added ability to set the radio name manually ([bbdc97e](bbdc97e))
* release ([48a2fa6](48a2fa6))
* remove not existing directive from avatar ([2d1220c](2d1220c))
* removed unused ItAbstractComponent from header and navbar ([0ebe1e2](0ebe1e2))
* **textarea:** added to set textarea as readonly ([409c411](409c411))
* use button instead of a for avatar dropdown ([3d0d492](3d0d492))
* use fill-opacity to display the sorting arrows correctly ([3516dae](3516dae))
* use library dependencies inside library provide ([4409748](4409748))

### Features

* add label waria on more components ([95d2b9d](95d2b9d))
* add megamenu component ([0da7bee](0da7bee))
* add navbar ([13ad966](13ad966))
* add sidebar component ([cfb85c7](cfb85c7))
* add sorting to table ([0f039f4](0f039f4))
* improve header component ([b2552b9](b2552b9))
* **pipes:** added date-ago pipe ([97b3aed](97b3aed))
* **pipes:** added duration pipe ([6beea0f](6beea0f))
* split autocomple to another component ([082ee93](082ee93)), closes [#302](#302)
* upgrade to angular 17 ([072df92](072df92))
* **upgrade-major:** fixed prerelease versioning ([fe3781d](fe3781d))
* **utils:** added date utils ([2b22506](2b22506))

### Performance Improvements

* improved all BooleanInput with angular transform function ([0956e52](0956e52))
@github-actions GitHub Actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astagi astagi

Labels
enhancement New feature or request new component released on @prerelease released
Projects
None yet
Milestone
Version 1.0.0
Development

Successfully merging a pull request may close this issue.

chore(deps): upgrade bsi to the latest version italia/design-angular-kit
2 participants
@astagi @AntoninoBonanno