Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix circuit breaker task #9022

Merged
merged 2 commits into from
Feb 23, 2021
Merged

fix circuit breaker task #9022

merged 2 commits into from
Feb 23, 2021

Conversation

masquee
Copy link
Contributor

@masquee masquee commented Feb 22, 2021

use consecutive5xxErrors instead of consecutiveErrors

[ ] Configuration Infrastructure
[X] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@masquee masquee requested a review from a team as a code owner February 22, 2021 05:43
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 22, 2021
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2021
@istio-testing
Copy link
Contributor

Hi @masquee. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@craigbox
Copy link
Contributor

/assign @istio/wg-networking-maintainers

Can you confirm if this field has changed? The docs at https://istio.io/latest/docs/reference/config/networking/destination-rule/ don't mention consecutiveErrors but the examples on the page do.

@craigbox
Copy link
Contributor

there's a warning saying "outlier detection consecutive errors is deprecated, use consecutiveGatewayErrors or consecutive5xxErrors instead"

Looks like we should update our reference docs too

@craigbox craigbox requested a review from a team February 22, 2021 11:46
@ericvn
Copy link
Contributor

ericvn commented Feb 22, 2021

Reference docs were updated in master with istio/api#1885. Not sure if that whole PR should be cherrypicked to 1.9 or not?

@ericvn ericvn mentioned this pull request Feb 22, 2021
Merged
@ericvn
Copy link
Contributor

ericvn commented Feb 22, 2021

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Feb 22, 2021
@ericvn
Copy link
Contributor

ericvn commented Feb 22, 2021

@masquee You need to run a make gen which will create an updated snips.sh which you will need to add to this PR.

@masquee
Copy link
Contributor Author

masquee commented Feb 23, 2021 •
edited
Loading

@masquee You need to run a make gen which will create an updated snips.sh which you will need to add to this PR.

done.
This PR should be cherrypicked to release-1.9, but i don't know how to add cherrypick/release-1.9 label 😅

@istio-testing istio-testing merged commit cd0d07d into istio:master Feb 23, 2021
@ericvn
Copy link
Contributor

ericvn commented Feb 23, 2021

/cherrypick release-1.9

@istio-testing istio-testing mentioned this pull request Feb 23, 2021
Merged
@istio-testing
Copy link
Contributor

@ericvn: new pull request created: #9042

In response to this:

/cherrypick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@masquee masquee deleted the fix/circuit_breaker branch February 24, 2021 03:47
istio-testing added a commit that referenced this pull request Feb 25, 2021
@wbartosz @bianpengyuan
@smawson @istio-testing @frankbu @howardjohn @jacob-delgado @douglas-reid @lei-tang @rhrazdil @stevenctl @Kang-Bae @masquee @zufardhiyaulhaq @yangminzhu @JimmyCYJ @brian-avery
Keep polidea-update in sync with master (#9057)
59f2fa3 
* Update customize prom scraping instruction. (#8976)

* Update customize prom scraping instruction.

* Update content/en/docs/ops/integrations/prometheus/index.md

Co-authored-by: Sven Mawson <sven@google.com>

Co-authored-by: Sven Mawson <sven@google.com>

* IstioCon blog post (#8984)

Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>

* s/service-apis/gateway-api/ (#8988)

* Update index.md

* Update index.md

* Revert "remove rbac instruction (#8442)" (#8990)

This reverts commit a65a859.

* Update observability best practices (#8897)

* Update observability best practices

* Fix linting issue

* Try and clarify prometheus install

* Update content/en/docs/ops/best-practices/observability/index.md

Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>

* Move to observability page

Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>

* Add doc about how to work around missing metric expiry. (#8948)

* Add doc about how to work around missing metric expiry.

* address comment.

* lint

* add spelling change

* fix

* Update content/en/faq/metrics-and-logs/telemetry-v1-vs-v2.md

Co-authored-by: Douglas Reid <douglas-reid@users.noreply.github.com>

Co-authored-by: Douglas Reid <douglas-reid@users.noreply.github.com>

* Add initial security best practices documentation (#8952)

* Clarify Prometheus TLS settings. (#8962)

* Clarify Prometheus TLS settings.

* Update content/en/docs/ops/integrations/prometheus/index.md

Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>

* Update content/en/docs/ops/integrations/prometheus/index.md

Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>

* Update content/en/docs/ops/integrations/prometheus/index.md

Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>

Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>

* Automator: update common-files@master in istio/istio.io@master (#8997)

* Automator: update istio.io@ reference docs (#8998)

* Automator: update istio.io@ reference docs (#9004)

* Make attribute gen yaml file valid. (#9000)

* Fix the client IP addresses for the authz ingress task (#9002)

* Fix link to Configuration title (#9009)

Signed-off-by: Radim Hrazdil <rhrazdil@redhat.com>

* Automator: update istio.io@ reference docs (#9019)

* Automator: update istio@ test reference (#9021)

* Use istio-ecosystem wasm extensions repo in extensibility concept page. (#9018)

* add a troubleshooting guide for multicluster (#8957)

* add a troubleshooting guide for multicluster

* fix meta

* fix meta

* address review comments

* shift weight

* rel link

* lint

* fix link

* hard to tell what our mdlint customizations are...

* fix mc guide link

* add more context to high-level issues

* cleanup phrasing

* Remove fixed limitation warning (#9034)

This issue no longer exists, I verified via the code and tested it myself as well.

* Fixed "are is" to "are"  and addressed an incorrect link (#9035)

* fixing a typo

* changed the link to go directly to canary upgrades page

* Automator: update istio.io@ reference docs (#9036)

* fix circuit breaker task (#9022)

* fix circuit breaker task

* gen

* Add documentation for Analysis messsage IST0134 ServiceEntryAddresses… (#9020)

* Add documentation for Analysis messsage IST0134 ServiceEntryAddressesRequired

Signed-off-by: zufardhiyaulhaq <zufardhiyaulhaq@gmail.com>

* Apply suggestions from code review

Co-authored-by: Ram Vennam <rvennam@us.ibm.com>

* Update content/en/docs/reference/config/analysis/ist0134/index.md

Co-authored-by: Ram Vennam <rvennam@us.ibm.com>

Co-authored-by: Ram Vennam <rvennam@us.ibm.com>

* Add blog for zero configuration Istio (#9025)

* Add blog for zero configuration Istio

The intent here is to show off what Istio provides out of the box, to
attempt to counteract some of the reputation Istio has gotten for being
over complicated/requiring too many CRDs.

* fix links

* Address comments

* Fix examples for newer kubectl (#9045)

* Fix istio.io tests when moving to later kubectl (#9046)

* Automator: update istio.io@ reference docs (#9047)

* Ignore error on first kiali apply (#9048)

* Ignore some errors (#9049)

* Fix syntax on local rate limiting (#9044)

* Add cross references to virtual machine docs (#8913)

* Add cross references to virtual machine docs

* Sven's suggestions

* Update content/en/docs/ops/diagnostic-tools/virtual-machines/index.md

Co-authored-by: Sven Mawson <sven@google.com>

Co-authored-by: Sven Mawson <sven@google.com>

* update authz troubleshoot common problems (#9043)

* update authz troubleshoot common problems

* update

* Add out-of-mesh server metadata info into telemetry v2 faq. (#9017)

* Add out-of-mesh server metadata info into telemetry v2 faq.

* Update content/en/faq/metrics-and-logs/telemetry-v1-vs-v2.md

Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>

* reword

Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>

* Release notes for 1.7.8 (#9054)

* Announce EOL for Istio 1.7 (#9005)

* Release notes for 1.7.7

* Update content/en/news/releases/1.7.x/announcing-1.7.7/index.md

Co-authored-by: Brian Avery <bavery@redhat.com>

* update

* update

* Announce EOL for Istio 1.7

* delay to 02-25

* Delete index.md

Co-authored-by: Brian Avery <bavery@redhat.com>

Co-authored-by: Pengyuan Bian <bianpengyuan@google.com>
Co-authored-by: Sven Mawson <sven@google.com>
Co-authored-by: Istio Automation <istio-testing-bot@google.com>
Co-authored-by: Frank Budinsky <frankb@ca.ibm.com>
Co-authored-by: craigbox <craigbox@google.com>
Co-authored-by: John Howard <howardjohn@google.com>
Co-authored-by: jacob-delgado <jacob.delgado@volunteers.acasi.info>
Co-authored-by: Douglas Reid <douglas-reid@users.noreply.github.com>
Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>
Co-authored-by: lei-tang <32078630+lei-tang@users.noreply.github.com>
Co-authored-by: Radim Hrazdil <32546791+rhrazdil@users.noreply.github.com>
Co-authored-by: Steven Landow <steven@stlcomputerservices.com>
Co-authored-by: Kang-Bae <59033920+Kang-Bae@users.noreply.github.com>
Co-authored-by: masquee <okayanz@outlook.com>
Co-authored-by: Zufar Dhiyaulhaq <zufardhiyaulhaq@gmail.com>
Co-authored-by: Ram Vennam <rvennam@us.ibm.com>
Co-authored-by: Ryan Baker <ryan.baker@c2fo.com>
Co-authored-by: Yangmin Zhu <ymzhu@google.com>
Co-authored-by: Jimmy Chen <28548492+JimmyCYJ@users.noreply.github.com>
Co-authored-by: Brian Avery <bavery@redhat.com>
@SpecialYang
Copy link
Member

/cherrypick release-1.8

@istio-testing
Copy link
Contributor

@SpecialYang: new pull request created: #9486

In response to this:

/cherrypick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing mentioned this pull request Apr 8, 2021
Merged
@istio-testing
Copy link
Contributor

@ericvn: new pull request could not be created: failed to create pull request against istio/istio.io#release-1.9 from head istio-testing:cherry-pick-9022-to-release-1.9: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between istio:release-1.9 and istio-testing:cherry-pick-9022-to-release-1.9"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherrypick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvn ericvn ericvn approved these changes

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@masquee @istio-testing @craigbox @ericvn @SpecialYang @howardjohn