Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark Lightstep provider deprecated #2635

Merged
merged 3 commits into from
Jan 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
865 changes: 434 additions & 431 deletions mesh/v1alpha1/config.pb.go

Large diffs are not rendered by default.

7 changes: 3 additions & 4 deletions mesh/v1alpha1/config.proto
Original file line number Diff line number Diff line change
Expand Up @@ -486,11 +486,10 @@ message MeshConfig {
EnvoyExternalAuthorizationGrpcProvider envoy_ext_authz_grpc = 3;
// Configures a tracing provider that uses the Zipkin API.
ZipkinTracingProvider zipkin = 4;
// $hide_from_docs
// Configures a Lightstep tracing provider.
// Note: For Istio 1.15+, configuring this provider will result in
// using an OpenTelemetryTracingProvider configured specially for
// Lightstep. This is part of the Lightstep transition to OpenTelemetry.
LightstepTracingProvider lightstep = 5;
// Deprecated: For Istio 1.15+, please use an OpenTelemetryTracingProvider instead, more details can be found at https://github.com/istio/istio/issues/40027
LightstepTracingProvider lightstep = 5 [deprecated=true];
zirain marked this conversation as resolved.
Show resolved Hide resolved
// Configures a Datadog tracing provider.
DatadogTracingProvider datadog = 6;
// Configures a Stackdriver provider.
Expand Down
6 changes: 4 additions & 2 deletions mesh/v1alpha1/istio.mesh.v1alpha1.gen.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 0 additions & 14 deletions mesh/v1alpha1/istio.mesh.v1alpha1.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion proto.lock
Original file line number Diff line number Diff line change
Expand Up @@ -34981,7 +34981,13 @@
{
"id": 5,
"name": "lightstep",
"type": "LightstepTracingProvider"
"type": "LightstepTracingProvider",
"options": [
{
"name": "deprecated",
"value": "true"
}
]
},
{
"id": 6,
Expand Down
10 changes: 10 additions & 0 deletions releasenotes/notes/2635.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
apiVersion: release-notes/v2

kind: feature
area: telemetry
issue:
- https://github.com/istio/istio/issues/40027

releaseNotes:
- |
**Deprecated** Lightstep provider, please use OpenTelemetry provider instead.