Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark Lightstep provider deprecated #2635

Merged
merged 3 commits into from
Jan 30, 2023
Merged

mark Lightstep provider deprecated #2635

merged 3 commits into from
Jan 30, 2023

Conversation

zirain
Copy link
Member

@zirain zirain commented Jan 17, 2023 •
edited
Loading

@zirain zirain requested a review from a team as a code owner January 17, 2023 08:44
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 17, 2023
@zirain zirain added the release-notes-none Indicates a PR that does not require release notes. label Jan 17, 2023
@zirain
Copy link
Member Author

zirain commented Jan 17, 2023

/test release-notes

@ericvn
Copy link

ericvn commented Jan 23, 2023

Should there be a release note if we are deprecating? Maybe it will be elsewhere?

@zirain zirain removed the release-notes-none Indicates a PR that does not require release notes. label Jan 28, 2023
@zirain
Copy link
Member Author

zirain commented Jan 28, 2023

Should there be a release note if we are deprecating? Maybe it will be elsewhere?

updated

@zirain zirain added the cherrypick/release-1.17 Set this label on a PR to auto-merge it to the release-1.17 branch label Jan 28, 2023
linsun
linsun approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@linsun linsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for adding the release note

@istio-testing istio-testing merged commit 522813c into istio:master Jan 30, 2023
@istio-testing istio-testing mentioned this pull request Jan 30, 2023
Merged
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #2663

@ericvn ericvn mentioned this pull request Jan 30, 2023
Merged
@zirain zirain deleted the lightstep branch January 31, 2023 01:31
gabomarf pushed a commit to SpecialYang/api that referenced this pull request Feb 7, 2023
@zirain @gabomarf
mark Lightstep provider deprecated (istio#2635)
ef25b14 
* mark Lightstep provider deprecated

* hide from doc

* add release-notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linsun linsun linsun approved these changes

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

Assignees
No one assigned
Labels
cherrypick/release-1.17 Set this label on a PR to auto-merge it to the release-1.17 branch size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zirain @ericvn @istio-testing @linsun @hzxuzhonghu