Add regex rewrite

[SpecialYang]

In our gateway case, we definitely need this awesome feature to meet so many path routes. Maybe EnvoyFilter can support regex rewrite for data plane. But we are tired to name these routes that require regular rewriting. Only if we pick meaningful names for these routes, EnvoyFilter can match these route names and apply regex rewrite policy. Adding regex rewrite api for rewrite in HTTPRoute is the easy way to fix this case. I think someone needs this feature like me.

Based on this pr #1566, introduce RegexMatchAndSubstitute which may be used in the future for similar cases.
@howardjohn @hzxuzhonghu

Fixes istio/istio#22290 and istio/istio#24172.

[istio-policy-bot]

😊 Welcome @SpecialYang! This is either your first contribution to the Istio api repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[istio-testing]

Hi @SpecialYang. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[SpecialYang]

@googlebot I consent

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[howardjohn]

I am personally fine with this, but wanted to echo @costinm concern: #1566 (comment)

At least we should bounce the idea with the K8S Services WG - and the other projects planning to support the K8S APIs.
I assume since this didn't make it to 1.9 we can afford few weeks to discuss with the relevant WGs.

[hzxuzhonghu]

lgtm

At least we should bounce the idea with the K8S Services WG

Is this the service-apis?

[SpecialYang]

I am personally fine with this, but wanted to echo @costinm concern: #1566 (comment)

At least we should bounce the idea with the K8S Services WG - and the other projects planning to support the K8S APIs.
I assume since this didn't make it to 1.9 we can afford few weeks to discuss with the relevant WGs.

Same question. Why is it related to service APIs?

The regex rewrite policy for uri is basic feature in most gateway products. Our gateway envoy get runtime configs from istiod via xds protocol. We must apply many EnvoyFilter configs and pick up meaningful names for target routes. We want an easy way just like configuring the regex rewrite policy directly in HTTPRoute, which is clear.

As I know, current istiod use RE2 for all regex match cases. I think we can also use it in regex rewrite until istiod support different regex styles.

I'm sure many users will look forward to this feature. Thanks.

[gengleilei]

Great. adding regular-based rewriting is necessary.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[SpecialYang]

I am personally fine with this, but wanted to echo @costinm concern: #1566 (comment)

At least we should bounce the idea with the K8S Services WG - and the other projects planning to support the K8S APIs.
I assume since this didn't make it to 1.9 we can afford few weeks to discuss with the relevant WGs.

Same question. Why is it related to service APIs?

The regex rewrite policy for uri is basic feature in most gateway products. Our gateway envoy get runtime configs from istiod via xds protocol. We must apply many EnvoyFilter configs and pick up meaningful names for target routes. We want an easy way just like configuring the regex rewrite policy directly in HTTPRoute, which is clear.

As I know, current istiod use RE2 for all regex match cases. I think we can also use it in regex rewrite until istiod support different regex styles.

I'm sure many users will look forward to this feature. Thanks.

@howardjohn @costinm PTAL. Thanks.

[istio-policy-bot]

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

[gabomarf]

Can you review this PR, please ?

@dcberg
@duderino
@linsun
@louiscryan
@nrjpoddar
@smawson
@istio/technical-oversight-committee

[istio-testing]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[timonwong]

Seems this is completed in #2753

[SpecialYang]

Fixed by #2753.