Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: code tidy up and new test #1036

Merged
merged 3 commits into from
Mar 28, 2019
Merged

Commits on Mar 19, 2019

  1. Test that the instrument command returns unmodified source if there i…

    …s no transform found for a file extension.
    
    Currently this behaviour can only be reached when trying to instrument a single file.
    In the case of instrumenting a directory, files with an extension with no matching transform are filtered out before they can be instrumented.
    Andrew Finlay committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    7e0fbe5 View commit details
    Browse the repository at this point in the history
  2. Cleanup instrumentation code again with a focus on paths

    The main aim of this has been to clarify whether we're working with relative or absolute file paths, and removing unnecessary transformations.  Although I've made a few other 'small' changes here and there.
    
    Key changes:
    	* Created a new private method `NYC._transform`, common to `_maybeInstrumentSource` and `instrumentAllFiles`.
    	* Renamed the param in `walkAllFiles` forEach handler to `relFile` to explicitly state the file representation being used.
    	* Let the `addAllFiles` visitor function rely on `testExclude` to determine which files to instrument
    Andrew Finlay committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    a054fbc View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2019

  1. Address review concerns

    Andrew Finlay committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    82bb259 View commit details
    Browse the repository at this point in the history