chore: code tidy up and new test #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 20, 2019 10:02
…s no transform found for a file extension. Currently this behaviour can only be reached when trying to instrument a single file. In the case of instrumenting a directory, files with an extension with no matching transform are filtered out before they can be instrumented.
The main aim of this has been to clarify whether we're working with relative or absolute file paths, and removing unnecessary transformations. Although I've made a few other 'small' changes here and there. Key changes: * Created a new private method `NYC._transform`, common to `_maybeInstrumentSource` and `instrumentAllFiles`. * Renamed the param in `walkAllFiles` forEach handler to `relFile` to explicitly state the file representation being used. * Let the `addAllFiles` visitor function rely on `testExclude` to determine which files to instrument
AndrewFinlay
changed the title
coreyfarrell
requested changes
Mar 20, 2019
coreyfarrell
approved these changes
Mar 21, 2019
JaKXz
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup instrumentation code again with a focus on absolute and relative paths
The main aim of this has been to clarify whether we're working with relative or absolute file paths, and removing unnecessary transformations. Although I've made a few other 'small' changes here and there.
Key changes:
NYC._transform, common to_maybeInstrumentSourceandinstrumentAllFiles.walkAllFilesforEach handler torelFileto explicitly state the file representation being used.addAllFilesvisitor function rely ontestExcludeto determine which files to instrument