test: Fixed duplicate test names and added eslint rules to detect dup… #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rc-davis
force-pushed
the
feat/dots-in-paths
branch
from
82c526b to
8b7472e
Compare
alexanderleegs
requested changes
May 31, 2022
There was a problem hiding this comment.
The duplicate test rule looks really helpful! I think it might be better if the tests were named appropriately though - the ones you've changed actually appear to be named incorrectly, thanks for pointing them out! I've left comments for what these are actually testing
newroutes/authenticatedSites/__tests__/ResourceCategories.spec.js
Outdated
Show resolved
Hide resolved
newroutes/authenticatedSites/__tests__/ResourceCategories.spec.js
Outdated
Show resolved
Hide resolved
alexanderleegs
approved these changes
May 31, 2022
Merged
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
#448) * test: Fixed duplicate test names and added eslint rules to detect duplicates. * test: fixed package-lock.json. * test: reset package-lock file format to version 1. * test: added more descriptive test names to previous duplicates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…licates.