test: Fixed duplicate test names and added eslint rules to detect dup… (

#448)

* test: Fixed duplicate test names and added eslint rules to detect duplicates.

* test: fixed package-lock.json.

* test: reset package-lock file format to version 1.

* test: added more descriptive test names to previous duplicates.

.eslintrc.json

@@ -3,14 +3,15 @@
         "browser": true,
         "commonjs": true,
         "es2021": true,
-        "jest": true
+        "jest": true,
+        "jest/globals": true
     },
     "extends": [
         "airbnb-base",
         "prettier",
         "plugin:import/typescript"
     ],
-    "plugins": ["only-warn", "import"],
+    "plugins": ["only-warn", "import", "jest"],
     "parserOptions": {
         "ecmaVersion": 12
     },
@@ -65,15 +66,16 @@
                     }
                 ]
             }
-        ]
+        ],
+        "jest/no-identical-title": "error"
     },
     "overrides": [
         {
           "files": ["*.ts", "*.tsx"],
           "parser": "@typescript-eslint/parser",
           "extends": ["plugin:@typescript-eslint/recommended"]
         }
-      ],    
+      ],
     "settings": {
         "import/parsers": {
             "@typescript-eslint/parser": [".ts", ".tsx"]

.gitignore

@@ -3,4 +3,5 @@ node_modules/
 .vscode/
 build/
 *.pem
-.env*
+.env*
+.idea/

newroutes/authenticatedSites/__tests__/Collections.spec.js

@@ -262,7 +262,7 @@ describe("Collections Router", () => {
       })
     })
 
-    it("accepts valid collection create requests with specified files and returns the details of the collection created", async () => {
+    it("accepts valid subcollection create requests with specified files and returns the details of the collection created", async () => {
       const collectionDetails = {
         newDirectoryName: subcollectionName,
         items: [
@@ -432,14 +432,14 @@ describe("Collections Router", () => {
         type: "file",
       },
     ]
-    it("rejects move requests with invalid body", async () => {
+    it("rejects move requests with empty body", async () => {
       await request(app)
         .post(`/${siteName}/collections/${collectionName}/move`)
         .send({})
         .expect(400)
     })
 
-    it("rejects move requests with invalid body", async () => {
+    it("rejects move requests for items with invalid type", async () => {
       await request(app)
         .post(`/${siteName}/collections/${collectionName}/move`)
         .send({
@@ -449,7 +449,7 @@ describe("Collections Router", () => {
         .expect(400)
     })
 
-    it("rejects move requests with invalid body", async () => {
+    it("rejects move requests with with no specified target", async () => {
       await request(app)
         .post(`/${siteName}/collections/${collectionName}/move`)
         .send({ items })

newroutes/authenticatedSites/__tests__/MediaCategories.spec.js

@@ -203,7 +203,7 @@ describe("Media Categories Router", () => {
         .expect(400)
     })
 
-    it("rejects move requests with invalid body", async () => {
+    it("rejects move requests for items with invalid type", async () => {
       await request(app)
         .post(`/${siteName}/media/${directoryName}/move`)
         .send({
@@ -213,7 +213,7 @@ describe("Media Categories Router", () => {
         .expect(400)
     })
 
-    it("rejects move requests with invalid body", async () => {
+    it("rejects move requests with no specified target", async () => {
       await request(app)
         .post(`/${siteName}/media/${directoryName}/move`)
         .send({ target: {}, items })

newroutes/authenticatedSites/__tests__/ResourceCategories.spec.js

@@ -192,7 +192,7 @@ describe("Resource Categories Router", () => {
         .expect(400)
     })
 
-    it("rejects move requests with invalid body", async () => {
+    it("rejects move requests for items with invalid type", async () => {
       await request(app)
         .post(
           `/${siteName}/resourceRoom/${resourceRoomName}/resources/${resourceCategoryName}/move`
@@ -204,7 +204,7 @@ describe("Resource Categories Router", () => {
         .expect(400)
     })
 
-    it("rejects move requests with invalid body", async () => {
+    it("rejects move requests with with no specified target", async () => {
       await request(app)
         .post(
           `/${siteName}/resourceRoom/${resourceRoomName}/resources/${resourceCategoryName}/move`

newroutes/authenticatedSites/__tests__/UnlinkedPages.spec.js

@@ -262,7 +262,7 @@ describe("Unlinked Pages Router", () => {
       await request(app).post(`/${siteName}/pages/move`).send({}).expect(400)
     })
 
-    it("rejects move requests with invalid body", async () => {
+    it("rejects move requests for items with invalid type", async () => {
       await request(app)
         .post(`/${siteName}/pages/move`)
         .send({
@@ -272,7 +272,7 @@ describe("Unlinked Pages Router", () => {
         .expect(400)
     })
 
-    it("rejects move requests with invalid body", async () => {
+    it("rejects move requests with no specified target", async () => {
       await request(app)
         .post(`/${siteName}/pages/move`)
         .send({ items })