Merge to production - 17 Jun 2021 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: install prettier * feat: update prettier options * feat: install eslint * feat: setup eslint configurations, use airbnb-base as a default * feat: add eslint ignore file * feat: add integration for prettier with eslint * feat: add linting, formatting, and checking scripts to package.json * fix: add Prettier as a plugin for eslint * feat: install eslint-plugin-prettier * chore: reformat eslint config * chore: update prettierIgnore * chore: install eslint import sorting plugin Co-authored-by: jiehao <jiehao@open.gov.sg>
* Lint: misc files * Fix: remove unused file * Fix: update prettierignore to ignore package-lock
Style: Linting for Classes Files
lint: routes
* style: install module aliases, setup aliases This commit installs the module-alias package, and establishes aliases for top-level directories * style: replace requires with aliases * style: require module-alias as app root * chore: install eslint import resolver alias plugin * style: define import order in eslint config * style: automated fix for import order * style: manual fixes to import order
This commit replaces the `plugin:prettier-recommended` with the original `prettier` plugin. This is because our config does not work with `plugin:prettier-recommended`. The desired behavior when we run `npx eslint --fix .` is that all linting bugs are fixed, but formatting issues are ignored. However, we discovered that when we ran `npx eslint --fix .` with the `prettier-recommended` plugin, formatting issues were beign corrected as well. This is easily fixed by using the `prettier` plugin instead.
This commit adds path aliases to the jsconfig.json so that VS Code can understand our aliases and help us to autocomplete them.
fix: address bug in directory route
* fix: rename third_nav_title when renaming collection * fix: deslugify third_nav_title name
…quire manual attention (#203)
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
Merge to production - 17 Jun 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.