fix: modify third nav title when renaming subfolder #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #185.
Problem
The current
renameSubfolder
route method does the following:${folder}/${previousSubfolder}/${fileName}
to${folder}/${newSubfolder}/${fileName}
using git treescollection.yml
file within the collection folderHowever, this neglects to modify the
third_nav_title
fields within the collection subfolder files.Fix
This PR fixes the abovementioned problem by taking the following approach:
${folder}/${previousSubfolder}
folderthird_nav_title
field in each retrieved file${folder}/${newSubfolder}
foldercollection.yml
file within the collection folderNote
This fix - while functional - is not ideal because it just adds more business logic to the routes layer. We will clean this up in the upcoming backend refactor.