Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/0.54.0 #1033

Merged
merged 1 commit into from
Nov 14, 2023
Merged

release/0.54.0 #1033

merged 1 commit into from
Nov 14, 2023

Conversation

harishv7
Copy link
Contributor

@harishv7 harishv7 commented Nov 14, 2023

v0.54.0

  • fix(pagination): total length #1032
  • fix(staging-lite): apps were created for wrong br #1014
  • fix(cm): extra timeout #1027
  • fix(pagination): images fix pagination #1026
  • fix(media): change media sorting to addedTime descending #1019
  • 0.53.0 #1024

@harishv7 harishv7 mentioned this pull request Nov 14, 2023
@harishv7
Copy link
Contributor Author

harishv7 commented Nov 14, 2023

fix(pagination): total length #1032 - @kishore03109

  • go into a site with a lot of images/files (eg nlb-biblioasia)
  • search for a file
  • notice that number of page changes (ie, the last few pages are not empty)

fix(staging-lite): apps were created for wrong br #1014 - already verified

fix(cm): extra timeout #1027 - @kishore03109

fix(pagination): images fix pagination #1026 - @harishv7

  • Go into a repo with lots of images (at least > 15 since thats what we paginate by)
  • Search for any image that would be > 15th index when alphabeticaly ordered. (eg. seach for an image that start with z)
  • ensure that you can see the image in the modal

fix(media): change media sorting to addedTime descending #1019 - @harishv7

  • Navigate to any site and visit the images workspace as an email-login user
  • Verify that the images are sorted by their added time in descending order
  • Navigate to any site and visit the images workspace as a GitHub-login user
  • Verify that the images are still sorted by their file names in ascending order

Copy link

mergify bot commented Nov 14, 2023

⚠️ The sha of the head commit of this PR conflicts with #1034. Mergify cannot evaluate rules on this PR. ⚠️

Copy link
Contributor

@alexanderleegs alexanderleegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexanderleegs alexanderleegs merged commit c665dac into develop Nov 14, 2023
@mergify mergify bot deleted the release/0.54.0 branch November 14, 2023 10:46
This was referenced Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants