Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(staging-lite): apps were created for wrong br #1014

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix(staging-lite): apps were created for wrong br #1014

merged 1 commit into from
Nov 14, 2023

Conversation

kishore03109
Copy link
Contributor

@kishore03109 kishore03109 commented Nov 3, 2023 •
edited
Loading

Problem

Stagign lite apps were created with master and stagign branches on site create, when it should have been just the staging-lite branch,

Solution

change deployed branch

tested local function call directly, verified that

  1. staging lite creates just the lite branch
  2. main app with 2 branhces are created

@kishore03109 kishore03109 requested a review from a team November 3, 2023 01:58
@kishore03109 kishore03109 merged commit 0974c9a into develop Nov 14, 2023
@mergify mergify bot deleted the fix/siteCreateStagingLite branch November 14, 2023 05:40
@harishv7 harishv7 mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcshzj dcshzj dcshzj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kishore03109 @dcshzj