fix(j-s): Completed cases filter

[unakb]

Laga filteringu á Afgreidd mál - mál

What

Fix filtering of completed cases

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features
  • Enhanced case filtering logic to exclude cases awaiting confirmation, improving case management accuracy.

[coderabbitai]

Walkthrough

The changes in this pull request modify the filtering logic in the Cases.tsx file by adding an additional condition that excludes cases awaiting confirmation from the results. This adjustment refines the criteria for case selection, impacting how cases are processed within the application.

Changes

Files	Change Summary
apps/judicial-system/web/src/routes/Shared/Cases/Cases.tsx	Added a new exclusion criterion for cases awaiting confirmation in the filtering logic.

Possibly related PRs

• fix(j-s): Cancelled Unassigned Indictment #15910: This PR modifies the filtering logic within the same Cases.tsx file, indicating a direct connection in how cases are selected and displayed based on their states.
• feat(j-s): Confirmed court records #15921: This PR focuses on generating PDFs for confirmed court records, which may relate to case processing but does not directly connect to the filtering logic in Cases.tsx.
• fix(j-s): Don't show UI updates underneath a modal #15922: This PR alters the logic for determining the state of indictments in a different file, but it does not directly relate to the filtering logic in Cases.tsx.
• fix(j-s): Allow prison system users to see rulings #15935: This PR introduces changes to case file handling based on user roles and case types, which may indirectly relate to case management but does not connect directly to the filtering logic in Cases.tsx.
• fix(j-s): Merge Email #16011: This PR addresses case conclusions related to merges, which may affect case management but does not directly relate to the filtering logic in Cases.tsx.
• fix(j-s): Defender Case Info #16024: This PR focuses on improving the display of case information for defenders, which may relate to case management but does not connect directly to the filtering logic in Cases.tsx.

Suggested labels

automerge

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.77%. Comparing base (3594b6d) to head (1199e35).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16034      +/-   ##
==========================================
+ Coverage   36.73%   36.77%   +0.04%     
==========================================
  Files        6735     6733       -2     
  Lines      138305   138074     -231     
  Branches    39338    39243      -95     
==========================================
- Hits        50800    50775      -25     
+ Misses      87505    87299     -206     

Flag	Coverage Δ
judicial-system-api	19.40% <ø> (ø)
judicial-system-backend	55.22% <ø> (+0.03%)	⬆️
judicial-system-formatters	79.76% <ø> (ø)
judicial-system-web	28.71% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...icial-system/web/src/routes/Shared/Cases/Cases.tsx	72.97% <100.00%> (+0.24%)	⬆️

... and 53 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3594b6d...1199e35. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs 005b719 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed
➡️ Test Sessions change in coverage: 2 no change

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
judicial-system-web	0	0	0	338	0	1m 16.35s	1 no change	Link
web	0	0	0	84	0	33.1s	1 no change	Link

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c2b2a7e and 7d481f6.

Files selected for processing (1)

• apps/judicial-system/web/src/routes/Shared/Cases/Cases.tsx (1 hunks)

Additional context used

Path-based instructions (1)

apps/judicial-system/web/src/routes/Shared/Cases/Cases.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."