Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contentful-apps): Team member filter tags field #16006

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

RunarVestmann
Copy link
Member

@RunarVestmann RunarVestmann commented Sep 13, 2024

Team member filter tags field

What

  • It only makes sense to tag team members with tags that are available in the team list search filter (previously you could select any tag)

Why

  • We have more control in the CMS now and simplify the workflow of adding team members in the cms

Screenshots / Gifs

Before

image

After

Screenshot 2024-09-13 at 14 35 41

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features
    • Introduced a new component for filtering team members using tags in the Contentful application.
    • Users can select or deselect tags via checkboxes, enhancing the filtering process.
    • Improved user experience with a loading spinner and organized tag group display.

@RunarVestmann RunarVestmann added the automerge Merge this PR as soon as all checks pass label Sep 13, 2024
@RunarVestmann RunarVestmann requested a review from a team as a code owner September 13, 2024 14:33
Copy link
Contributor

coderabbitai bot commented Sep 13, 2024

Walkthrough

The changes introduce a new React component, TeamMemberFilterTagsField, in a Contentful application. This component allows users to filter team members by selecting tags through checkboxes. It fetches tag groups and tags using the Contentful Management API, manages local state for loading and selected tags, and implements a debouncing mechanism for efficient updates. The UI includes a loading spinner and a structured display of tags, enhancing the functionality for filtering team members.

Changes

File Path Change Summary
apps/contentful-apps/pages/fields/team-member-filter-tags-field.tsx Added a new React component for filtering team members by tags, utilizing Contentful Management API.

Possibly related PRs


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 62 lines in your changes missing coverage. Please review.

Project coverage is 36.83%. Comparing base (94f993e) to head (0ada394).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...pps/pages/fields/team-member-filter-tags-field.tsx 0.00% 62 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16006      +/-   ##
==========================================
- Coverage   36.84%   36.83%   -0.02%     
==========================================
  Files        6718     6719       +1     
  Lines      137732   137793      +61     
  Branches    39159    39171      +12     
==========================================
  Hits        50753    50753              
- Misses      86979    87040      +61     
Flag Coverage Δ
contentful-apps 5.89% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pps/pages/fields/team-member-filter-tags-field.tsx 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94f993e...0ada394. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

All test runs b6c5716 🔗

21 Total Test Services: 0 Failed, 21 Passed
🔻 Test Sessions change in coverage: 3 decreased, 88 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-web 0 0 0 2 0 8.88s 1 no change Link
api 0 0 0 4 0 3.03s 1 no change Link
application-api-files 0 0 0 12 0 6.28s 1 no change Link
application-core 0 0 0 90 0 20.32s 1 decreased (-0.62%) Link
application-system-api 0 0 0 111 2 3m 42.63s 1 no change Link
application-template-api-modules 0 0 0 109 0 1m 53.15s 1 no change Link
application-templates-accident-notification 0 0 0 98 0 20.42s 1 no change Link
application-templates-criminal-record 0 0 0 2 0 11.2s 1 no change Link
application-templates-driving-license 0 0 0 13 0 18.17s 1 no change Link
application-templates-example-payment 0 0 0 2 0 13.03s 1 no change Link

🔻 Code Coverage Decreases vs Default Branch (3)

  • application-core - jest 79.05% (-0.62%) - Details
  • contentful-apps - jest 5.11% (-0.15%) - Details
  • application-templates-parental-leave - jest 34.31% (-0.1%) - Details

@kodiakhq kodiakhq bot merged commit ad1b7cf into main Sep 14, 2024
30 checks passed
@kodiakhq kodiakhq bot deleted the feat/contentful-apps-team-member-filter-tags-field branch September 14, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants