feat(web): Generic List - UX improvements

[RunarVestmann]

Generic List - UX improvements

What

• Don't show "No results found" text during initial load
• Reduce content bouncing by setting a minHeight on the filter tag container
• Reset the page number when a user filters by tag

Why

• These changes improve the user experience

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features

  • Introduced a new style for filter tags in the Generic List component, enhancing layout and visual structure.
  • Improved pagination handling by resetting state when filters are modified or cleared.

• Bug Fixes

  • Refined the "no results found" message to avoid misleading feedback during loading states.
  • Updated loading indicators to accurately reflect data-fetching status.

• Documentation

  • Updated state management for loading indicators in the Team List component to improve user experience.

[coderabbitai]

Walkthrough

The pull request introduces several changes across multiple files, focusing on enhancing the pagination and filtering functionalities in the GenericList and TeamListSlice components. It adds a new CSS style for filter tags, modifies state management to reset pagination when filters change, and improves the loading state handling to accurately reflect data-fetching status.

Changes

File Path	Change Summary
apps/web/components/GenericList/GenericList.css.ts	Added a new CSS style filterTagsContainer with a minimum height of 32 pixels.
apps/web/components/GenericList/GenericList.tsx	Enhanced pagination handling by resetting state on filter changes, refined "no results found" condition, and improved loading state management.
apps/web/components/Organization/Slice/TeamListSlice/TeamListSlice.tsx	Modified loading state management to include a called property, ensuring accurate representation of data-fetching status.

Possibly related PRs

• feat(web): Team List - Display email, phone and tags for team members  #15947: This PR modifies the TeamListSlice.tsx file, indicating a direct connection in the handling of team member data and potentially related UI components.
• feat(web): Team List - Move frontend logic to the backend #15965: This PR involves changes to the TeamListSlice.tsx file, focusing on restructuring team member tag data, which aligns with the pagination and filtering enhancements made in the main PR.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 36.85%. Comparing base (f9c2668) to head (2fd9a94).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
apps/web/components/GenericList/GenericList.tsx	0.00%	19 Missing ⚠️
...Organization/Slice/TeamListSlice/TeamListSlice.tsx	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15983      +/-   ##
==========================================
- Coverage   36.85%   36.85%   -0.01%     
==========================================
  Files        6717     6717              
  Lines      137678   137683       +5     
  Branches    39139    39141       +2     
==========================================
  Hits        50741    50741              
- Misses      86937    86942       +5     

Flag	Coverage Δ
web	1.85% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...Organization/Slice/TeamListSlice/TeamListSlice.tsx	0.00% <0.00%> (ø)
apps/web/components/GenericList/GenericList.tsx	0.00% <0.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c2668...2fd9a94. Read the comment docs.

[datadog-island-is]

Datadog Report

Branch report: feature/web-generic-list-ux-improvements
Commit report: 5ceac68
Test service: web

✅ 0 Failed, 84 Passed, 0 Skipped, 29.58s Total Time
➡️ Test Sessions change in coverage: 1 no change