fix(income-plan): remove commented out code and add nullable #15812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
kodiakhq bot
added a commit
that referenced
this pull request
Sep 2, 2024
* set up payment plan template * change application name to income plan * add instructions page * implement conclusion screen * Change some texts after review * feat(tr): income plan table (#15340) * fix:add scopes * fix: use type * chore: add to codeowners * fix: codewners * WIP table * feat: update client * fix: handle 404 * fix: write applciation * Seeder file for adding scopes to @island.is/clients/api * chore: nx format:write update dirty files * use application and active field for options in table repeater, populate categories and types in income plan with info from TR, add readonly for fields in table repeater * get currencies from TR and populate dropdown, format input fields that display something regarding income, call withholding tax api from TR and implement some rules when adding income to the income plan * WIP call withholdind income plan api from TR * validation when adding income, wip tooltip on fields in table repeater, format number showed in income table * mock withholding tax and populate table, add readonly to table fields, change tooltip for checkbox and format * add review screen --------- Co-authored-by: Þorkell Máni Þorkelsson <mani@hugsmidjan.is> Co-authored-by: Þorkell Máni Þorkelsson <wowthorkell@gmail.com> Co-authored-by: ori.jonab <Jon.Arnar.Briem@origo.is> Co-authored-by: andes-it <builders@andes.is> * remove fake form steppers and call latest income plan * foreign income + populate table with latest income plan * format * add history logs and corresponding messages * feat(income-plan): text changes (#15636) * text changes * format * eligible and update after withholding tax and latest income plan outputs was changed * [TS-839] Calculate income per year (#15682) * update read me and add flow chart (#15669) * feat(income-plan): make more application card texts editable (#15754) * text changes * format * make open application button texts editable * format * chore: nx format:write update dirty files --------- Co-authored-by: andes-it <builders@andes.is> * [TS-848] Jafnar tekjur á mánuði (#15733) * [TS-849] uneven income (#15701) * feat(income-plan): send income plan (#15777) * WIP send income plan to TR * send income plan * remove * update eligible * default IKR * ts-853 change bottom button link * clean up * feat(income-plan): Add unit tests (#15778) * add unit tests for state transitions * add unit tests for utils * format * chore: nx format:write update dirty files --------- Co-authored-by: andes-it <builders@andes.is> * [TS-847] start application at the first page when table has been filled (#15793) * add review and complete state to income plan + feature flag * validation was triggered * remove mock data * clean * feat(income-plan): Temporary calculation table (#15642) * set up temporary calculation page and data * add print screen custom component and messages * fix input and add to temporary calculation screen * [TS-823] temporary calculation plan page * Add validation to incomePlanTable - nonempty * Fixed query input * Added AlertMessage when no payments * Update temporary calculation query input * chore: nx format:write update dirty files --------- Co-authored-by: ylfahfa <yhafsteinsdottir@deloitte.is> Co-authored-by: karenbjorg <khalldorsdottir@deloitte.is> Co-authored-by: andes-it <builders@andes.is> * [TS-889] fix validation for currency (#15803) * if selected employment income and register uneven income, changing to other type of income then months still showed * foreign income per year where not validated * chore: nx format:write update dirty files * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Fixed typo in dataProviders externalDataId * Memoize the rows array to improve performance * Improve useEffect dependency array for better performance. * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * use Int instead of Number for number decorator * remove commented out code and nullable (#15812) * feat(income-plan): income plan conditions (#15820) * call income plan conditions api * Add incomePlanConditions to getApplicationExternalData * Add AlertMessage when no available prerequisites for temporary calculation * change income year * Update dataSchema * Update sendApplication and temporary calculation query input * Update unsetIncomePlan template action and added unit test --------- Co-authored-by: karenbjorg <khalldorsdottir@deloitte.is> * fix(table-repeater): move Item component and remove FC (#15830) * move Item component and remove FC * remove * move Item component * add variables to useEffect dependency array * add contentful id for income plan --------- Co-authored-by: ylfahfa <yhafsteinsdottir@deloitte.is> Co-authored-by: Þorkell Máni Þorkelsson <mani@hugsmidjan.is> Co-authored-by: Þorkell Máni Þorkelsson <wowthorkell@gmail.com> Co-authored-by: ori.jonab <Jon.Arnar.Briem@origo.is> Co-authored-by: andes-it <builders@andes.is> Co-authored-by: Ylfa <55542991+ylfahfa@users.noreply.github.com> Co-authored-by: veronikasif <54938148+veronikasif@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Veronika Sif <veronikasif@hotmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kodiakhq bot
added a commit
that referenced
this pull request
Sep 2, 2024
* set up payment plan template * change application name to income plan * add instructions page * implement conclusion screen * Change some texts after review * feat(tr): income plan table (#15340) * fix:add scopes * fix: use type * chore: add to codeowners * fix: codewners * WIP table * feat: update client * fix: handle 404 * fix: write applciation * Seeder file for adding scopes to @island.is/clients/api * chore: nx format:write update dirty files * use application and active field for options in table repeater, populate categories and types in income plan with info from TR, add readonly for fields in table repeater * get currencies from TR and populate dropdown, format input fields that display something regarding income, call withholding tax api from TR and implement some rules when adding income to the income plan * WIP call withholdind income plan api from TR * validation when adding income, wip tooltip on fields in table repeater, format number showed in income table * mock withholding tax and populate table, add readonly to table fields, change tooltip for checkbox and format * add review screen --------- Co-authored-by: Þorkell Máni Þorkelsson <mani@hugsmidjan.is> Co-authored-by: Þorkell Máni Þorkelsson <wowthorkell@gmail.com> Co-authored-by: ori.jonab <Jon.Arnar.Briem@origo.is> Co-authored-by: andes-it <builders@andes.is> * remove fake form steppers and call latest income plan * foreign income + populate table with latest income plan * format * add history logs and corresponding messages * feat(income-plan): text changes (#15636) * text changes * format * eligible and update after withholding tax and latest income plan outputs was changed * [TS-839] Calculate income per year (#15682) * update read me and add flow chart (#15669) * feat(income-plan): make more application card texts editable (#15754) * text changes * format * make open application button texts editable * format * chore: nx format:write update dirty files --------- Co-authored-by: andes-it <builders@andes.is> * [TS-848] Jafnar tekjur á mánuði (#15733) * [TS-849] uneven income (#15701) * feat(income-plan): send income plan (#15777) * WIP send income plan to TR * send income plan * remove * update eligible * default IKR * ts-853 change bottom button link * clean up * feat(income-plan): Add unit tests (#15778) * add unit tests for state transitions * add unit tests for utils * format * chore: nx format:write update dirty files --------- Co-authored-by: andes-it <builders@andes.is> * [TS-847] start application at the first page when table has been filled (#15793) * add review and complete state to income plan + feature flag * validation was triggered * remove mock data * clean * feat(income-plan): Temporary calculation table (#15642) * set up temporary calculation page and data * add print screen custom component and messages * fix input and add to temporary calculation screen * [TS-823] temporary calculation plan page * Add validation to incomePlanTable - nonempty * Fixed query input * Added AlertMessage when no payments * Update temporary calculation query input * chore: nx format:write update dirty files --------- Co-authored-by: ylfahfa <yhafsteinsdottir@deloitte.is> Co-authored-by: karenbjorg <khalldorsdottir@deloitte.is> Co-authored-by: andes-it <builders@andes.is> * [TS-889] fix validation for currency (#15803) * if selected employment income and register uneven income, changing to other type of income then months still showed * foreign income per year where not validated * chore: nx format:write update dirty files * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Fixed typo in dataProviders externalDataId * Memoize the rows array to improve performance * Improve useEffect dependency array for better performance. * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * use Int instead of Number for number decorator * remove commented out code and nullable (#15812) * feat(income-plan): income plan conditions (#15820) * call income plan conditions api * Add incomePlanConditions to getApplicationExternalData * Add AlertMessage when no available prerequisites for temporary calculation * change income year * Update dataSchema * Update sendApplication and temporary calculation query input * Update unsetIncomePlan template action and added unit test --------- Co-authored-by: karenbjorg <khalldorsdottir@deloitte.is> * fix(table-repeater): move Item component and remove FC (#15830) * move Item component and remove FC * remove * move Item component * add variables to useEffect dependency array * add the year for which TR is currently accepting income plans * different description if applicant has accepted income plan * simplify --------- Co-authored-by: ylfahfa <yhafsteinsdottir@deloitte.is> Co-authored-by: Þorkell Máni Þorkelsson <mani@hugsmidjan.is> Co-authored-by: Þorkell Máni Þorkelsson <wowthorkell@gmail.com> Co-authored-by: ori.jonab <Jon.Arnar.Briem@origo.is> Co-authored-by: andes-it <builders@andes.is> Co-authored-by: Ylfa <55542991+ylfahfa@users.noreply.github.com> Co-authored-by: veronikasif <54938148+veronikasif@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Veronika Sif <veronikasif@hotmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
jonnigs
pushed a commit
that referenced
this pull request
Sep 12, 2024
* set up payment plan template * change application name to income plan * add instructions page * implement conclusion screen * Change some texts after review * feat(tr): income plan table (#15340) * fix:add scopes * fix: use type * chore: add to codeowners * fix: codewners * WIP table * feat: update client * fix: handle 404 * fix: write applciation * Seeder file for adding scopes to @island.is/clients/api * chore: nx format:write update dirty files * use application and active field for options in table repeater, populate categories and types in income plan with info from TR, add readonly for fields in table repeater * get currencies from TR and populate dropdown, format input fields that display something regarding income, call withholding tax api from TR and implement some rules when adding income to the income plan * WIP call withholdind income plan api from TR * validation when adding income, wip tooltip on fields in table repeater, format number showed in income table * mock withholding tax and populate table, add readonly to table fields, change tooltip for checkbox and format * add review screen --------- Co-authored-by: Þorkell Máni Þorkelsson <mani@hugsmidjan.is> Co-authored-by: Þorkell Máni Þorkelsson <wowthorkell@gmail.com> Co-authored-by: ori.jonab <Jon.Arnar.Briem@origo.is> Co-authored-by: andes-it <builders@andes.is> * remove fake form steppers and call latest income plan * foreign income + populate table with latest income plan * format * add history logs and corresponding messages * feat(income-plan): text changes (#15636) * text changes * format * eligible and update after withholding tax and latest income plan outputs was changed * [TS-839] Calculate income per year (#15682) * update read me and add flow chart (#15669) * feat(income-plan): make more application card texts editable (#15754) * text changes * format * make open application button texts editable * format * chore: nx format:write update dirty files --------- Co-authored-by: andes-it <builders@andes.is> * [TS-848] Jafnar tekjur á mánuði (#15733) * [TS-849] uneven income (#15701) * feat(income-plan): send income plan (#15777) * WIP send income plan to TR * send income plan * remove * update eligible * default IKR * ts-853 change bottom button link * clean up * feat(income-plan): Add unit tests (#15778) * add unit tests for state transitions * add unit tests for utils * format * chore: nx format:write update dirty files --------- Co-authored-by: andes-it <builders@andes.is> * [TS-847] start application at the first page when table has been filled (#15793) * add review and complete state to income plan + feature flag * validation was triggered * remove mock data * clean * feat(income-plan): Temporary calculation table (#15642) * set up temporary calculation page and data * add print screen custom component and messages * fix input and add to temporary calculation screen * [TS-823] temporary calculation plan page * Add validation to incomePlanTable - nonempty * Fixed query input * Added AlertMessage when no payments * Update temporary calculation query input * chore: nx format:write update dirty files --------- Co-authored-by: ylfahfa <yhafsteinsdottir@deloitte.is> Co-authored-by: karenbjorg <khalldorsdottir@deloitte.is> Co-authored-by: andes-it <builders@andes.is> * [TS-889] fix validation for currency (#15803) * if selected employment income and register uneven income, changing to other type of income then months still showed * foreign income per year where not validated * chore: nx format:write update dirty files * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Fixed typo in dataProviders externalDataId * Memoize the rows array to improve performance * Improve useEffect dependency array for better performance. * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * use Int instead of Number for number decorator * remove commented out code and nullable (#15812) * feat(income-plan): income plan conditions (#15820) * call income plan conditions api * Add incomePlanConditions to getApplicationExternalData * Add AlertMessage when no available prerequisites for temporary calculation * change income year * Update dataSchema * Update sendApplication and temporary calculation query input * Update unsetIncomePlan template action and added unit test --------- Co-authored-by: karenbjorg <khalldorsdottir@deloitte.is> * fix(table-repeater): move Item component and remove FC (#15830) * move Item component and remove FC * remove * move Item component * add variables to useEffect dependency array * add the year for which TR is currently accepting income plans * different description if applicant has accepted income plan * simplify --------- Co-authored-by: ylfahfa <yhafsteinsdottir@deloitte.is> Co-authored-by: Þorkell Máni Þorkelsson <mani@hugsmidjan.is> Co-authored-by: Þorkell Máni Þorkelsson <wowthorkell@gmail.com> Co-authored-by: ori.jonab <Jon.Arnar.Briem@origo.is> Co-authored-by: andes-it <builders@andes.is> Co-authored-by: Ylfa <55542991+ylfahfa@users.noreply.github.com> Co-authored-by: veronikasif <54938148+veronikasif@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Veronika Sif <veronikasif@hotmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...
Attach a link to issue if relevant
What
Specify what you're trying to achieve
Why
Specify why you need to achieve this
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist: