feat(income-plan): Temporary calculation table #15642

veronikasif · 2024-08-13T11:30:08Z

[TS-823] temporary calculation plan page

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

coderabbitai · 2024-08-13T11:30:16Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (1)

main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

datadog-island-is · 2024-08-13T12:15:49Z

Datadog Report

All test runs d7620b7 🔗

✅ 88 Total Test Services: 0 Failed, 86 Passed
🔻 Test Sessions change in coverage: 20 decreased, 37 increased, 142 no change

Test Services

This report shows up to 10 services

Service Name	Passed	Total Time	Code Coverage Change	Test Service View
`api`	4	4.49s	N/A	Link
`api-catalogue-services`	23	17.34s	N/A	Link
`api-domains-air-discount-scheme`	6	36.11s	N/A	Link
`api-domains-assets`	3	23.91s	N/A	Link
`api-domains-auth-admin`	18	11.64s	N/A	Link
`api-domains-communications`	5	41.83s	N/A	Link
`api-domains-criminal-record`	5	15.88s	N/A	Link
`api-domains-driving-license`	23	50.45s	N/A	Link
`api-domains-education`	8	30.92s	N/A	Link
`api-domains-health-insurance`	4	15.02s	N/A	Link

🔻 Code Coverage Decreases vs Default Branch (20)

This report shows up to 5 code coverage decreases.

services-search-indexer - jest 0% (-12.83%) - Details
file-storage - jest 55.71% (-1.14%) - Details
shared-utils - jest 30.27% (-0.71%) - Details
clients-zendesk - jest 56.86% (-0.42%) - Details
judicial-system-audit-trail - jest 70.03% (-0.27%) - Details

codecov · 2024-08-13T12:39:03Z

Codecov Report

Attention: Patch coverage is 38.29787% with 29 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/income-plan@b997592). Learn more about missing BASE report.

Files	Patch %	Lines
...e-administration/income-plan/src/lib/dataSchema.ts	0.00%	26 Missing ⚠️
...lib/socialInsuranceAdministrationClient.service.ts	0.00%	2 Missing ⚠️
...inistration/income-plan/src/lib/incomePlanUtils.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##             feat/income-plan   #15642   +/-   ##
===================================================
  Coverage                    ?   36.94%           
===================================================
  Files                       ?     6632           
  Lines                       ?   136073           
  Branches                    ?    38722           
===================================================
  Hits                        ?    50267           
  Misses                      ?    85806           
  Partials                    ?        0

Flag	Coverage Δ
air-discount-scheme-backend	`54.19% <ø> (?)`
air-discount-scheme-web	`0.00% <ø> (?)`
api	`3.42% <ø> (?)`
api-catalogue-services	`77.85% <ø> (?)`
api-domains-air-discount-scheme	`37.10% <ø> (?)`
api-domains-assets	`26.71% <ø> (?)`
api-domains-auth-admin	`53.90% <ø> (?)`
api-domains-communications	`40.61% <ø> (?)`
api-domains-criminal-record	`48.20% <ø> (?)`
api-domains-driving-license	`44.55% <ø> (?)`
api-domains-education	`33.89% <ø> (?)`
api-domains-health-insurance	`35.12% <ø> (?)`
api-domains-mortgage-certificate	`36.07% <ø> (?)`
api-domains-payment-schedule	`41.37% <ø> (?)`
application-api-files	`57.97% <ø> (?)`
application-core	`71.95% <ø> (?)`
application-system-api	`41.76% <38.29%> (?)`
application-template-api-modules	`23.68% <38.29%> (?)`
application-templates-accident-notification	`19.83% <ø> (?)`
application-templates-car-recycling	`3.12% <ø> (?)`
application-templates-criminal-record	`22.12% <ø> (?)`
application-templates-driving-license	`15.98% <ø> (?)`
application-templates-estate	`11.89% <ø> (?)`
application-templates-example-payment	`20.79% <ø> (?)`
application-templates-financial-aid	`12.09% <ø> (?)`
application-templates-general-petition	`18.86% <ø> (?)`
application-templates-health-insurance	`23.27% <ø> (?)`
application-templates-inheritance-report	`4.63% <ø> (?)`
application-templates-marriage-conditions	`10.47% <ø> (?)`
application-templates-mortgage-certificate	`44.39% <ø> (?)`
application-templates-parental-leave	`28.38% <ø> (?)`
application-types	`6.74% <ø> (?)`
application-ui-components	`1.52% <ø> (?)`
application-ui-shell	`21.18% <ø> (?)`
auth-admin-web	`2.43% <ø> (?)`
auth-nest-tools	`30.44% <ø> (?)`
auth-react	`22.95% <ø> (?)`
auth-shared	`75.00% <ø> (?)`
clients-charge-fjs-v2	`27.54% <ø> (?)`
clients-driving-license	`41.06% <ø> (?)`
clients-driving-license-book	`44.17% <ø> (?)`
clients-financial-statements-inao	`49.51% <ø> (?)`
clients-license-client	`1.83% <ø> (?)`
clients-middlewares	`73.03% <ø> (?)`
clients-regulations	`43.01% <ø> (?)`
clients-rsk-company-registry	`30.64% <ø> (?)`
clients-rsk-personal-tax-return	`38.00% <ø> (?)`
clients-smartsolutions	`12.77% <ø> (?)`
clients-syslumenn	`49.95% <ø> (?)`
clients-zendesk	`55.65% <ø> (?)`
cms	`0.43% <ø> (?)`
cms-translations	`39.77% <ø> (?)`
content-search-index-manager	`95.65% <ø> (?)`
content-search-toolkit	`8.50% <ø> (?)`
contentful-apps	`6.05% <ø> (?)`
dokobit-signing	`62.76% <ø> (?)`
download-service	`44.65% <ø> (?)`
email-service	`60.57% <ø> (?)`
feature-flags	`90.62% <ø> (?)`
file-storage	`52.89% <ø> (?)`
financial-aid-backend	`56.46% <ø> (?)`
financial-aid-shared	`19.03% <ø> (?)`
icelandic-names-registry-backend	`54.36% <ø> (?)`
infra-nest-server	`48.33% <ø> (?)`
infra-tracing	`43.24% <ø> (?)`
island-ui-core	`28.76% <ø> (?)`
judicial-system-api	`18.21% <ø> (?)`
judicial-system-audit-trail	`68.44% <ø> (?)`
judicial-system-backend	`56.22% <ø> (?)`
judicial-system-formatters	`80.31% <ø> (?)`
judicial-system-message	`66.73% <ø> (?)`
judicial-system-message-handler	`47.52% <ø> (?)`
judicial-system-scheduler	`69.22% <ø> (?)`
judicial-system-types	`50.88% <ø> (?)`
judicial-system-web	`28.58% <ø> (?)`
license-api	`42.92% <ø> (?)`
localization	`10.15% <ø> (?)`
logging	`48.43% <ø> (?)`
message-queue	`68.50% <ø> (?)`
nest-audit	`68.20% <ø> (?)`
nest-config	`78.00% <ø> (?)`
nest-feature-flags	`51.18% <ø> (?)`
nest-problem	`46.19% <ø> (?)`
nest-sequelize	`94.44% <ø> (?)`
nest-swagger	`51.71% <ø> (?)`
nova-sms	`62.09% <ø> (?)`
portals-admin-regulations-admin	`2.02% <ø> (?)`
portals-core	`16.22% <ø> (?)`
reference-backend	`50.31% <ø> (?)`
regulations	`16.78% <ø> (?)`
residence-history	`85.00% <ø> (?)`
services-auth-admin-api	`51.10% <ø> (?)`
services-auth-delegation-api	`61.55% <ø> (?)`
services-auth-ids-api	`53.89% <ø> (?)`
services-auth-personal-representative	`48.12% <ø> (?)`
services-auth-personal-representative-public	`43.98% <ø> (?)`
services-auth-public-api	`52.00% <ø> (?)`
services-documents	`61.09% <ø> (?)`
services-endorsements-api	`55.10% <ø> (?)`
services-sessions	`65.59% <ø> (?)`
services-university-gateway	`48.59% <ø> (?)`
services-user-notification	`48.05% <ø> (?)`
services-user-profile	`62.36% <ø> (?)`
shared-components	`27.80% <ø> (?)`
shared-form-fields	`31.79% <ø> (?)`
shared-mocking	`64.62% <ø> (?)`
shared-pii	`92.85% <ø> (?)`
shared-problem	`87.50% <ø> (?)`
shared-utils	`29.87% <ø> (?)`
skilavottord-ws	`23.57% <ø> (?)`
web	`1.88% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...tration/social-insurance-administration.service.ts	`35.05% <100.00%> (ø)`
...-insurance-administration/income-plan/src/index.ts	`100.00% <100.00%> (ø)`
...stration/income-plan/src/lib/IncomePlanTemplate.ts	`16.32% <100.00%> (ø)`
...nce-administration/income-plan/src/lib/messages.ts	`100.00% <ø> (ø)`
libs/application/types/src/lib/ApplicationTypes.ts	`100.00% <ø> (ø)`
...inistration/income-plan/src/lib/incomePlanUtils.ts	`21.27% <0.00%> (ø)`
...lib/socialInsuranceAdministrationClient.service.ts	`38.77% <0.00%> (ø)`
...e-administration/income-plan/src/lib/dataSchema.ts	`12.90% <0.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b997592...6422322. Read the comment docs.

ylfahfa

Snilld! 🥇

…/island-is/island.is into feat/temporary-calculation-table

* set up payment plan template * change application name to income plan * add instructions page * implement conclusion screen * Change some texts after review * feat(tr): income plan table (#15340) * fix:add scopes * fix: use type * chore: add to codeowners * fix: codewners * WIP table * feat: update client * fix: handle 404 * fix: write applciation * Seeder file for adding scopes to @island.is/clients/api * chore: nx format:write update dirty files * use application and active field for options in table repeater, populate categories and types in income plan with info from TR, add readonly for fields in table repeater * get currencies from TR and populate dropdown, format input fields that display something regarding income, call withholding tax api from TR and implement some rules when adding income to the income plan * WIP call withholdind income plan api from TR * validation when adding income, wip tooltip on fields in table repeater, format number showed in income table * mock withholding tax and populate table, add readonly to table fields, change tooltip for checkbox and format * add review screen --------- Co-authored-by: Þorkell Máni Þorkelsson <mani@hugsmidjan.is> Co-authored-by: Þorkell Máni Þorkelsson <wowthorkell@gmail.com> Co-authored-by: ori.jonab <Jon.Arnar.Briem@origo.is> Co-authored-by: andes-it <builders@andes.is> * remove fake form steppers and call latest income plan * foreign income + populate table with latest income plan * format * add history logs and corresponding messages * feat(income-plan): text changes (#15636) * text changes * format * eligible and update after withholding tax and latest income plan outputs was changed * [TS-839] Calculate income per year (#15682) * update read me and add flow chart (#15669) * feat(income-plan): make more application card texts editable (#15754) * text changes * format * make open application button texts editable * format * chore: nx format:write update dirty files --------- Co-authored-by: andes-it <builders@andes.is> * [TS-848] Jafnar tekjur á mánuði (#15733) * [TS-849] uneven income (#15701) * feat(income-plan): send income plan (#15777) * WIP send income plan to TR * send income plan * remove * update eligible * default IKR * ts-853 change bottom button link * clean up * feat(income-plan): Add unit tests (#15778) * add unit tests for state transitions * add unit tests for utils * format * chore: nx format:write update dirty files --------- Co-authored-by: andes-it <builders@andes.is> * [TS-847] start application at the first page when table has been filled (#15793) * add review and complete state to income plan + feature flag * validation was triggered * remove mock data * clean * feat(income-plan): Temporary calculation table (#15642) * set up temporary calculation page and data * add print screen custom component and messages * fix input and add to temporary calculation screen * [TS-823] temporary calculation plan page * Add validation to incomePlanTable - nonempty * Fixed query input * Added AlertMessage when no payments * Update temporary calculation query input * chore: nx format:write update dirty files --------- Co-authored-by: ylfahfa <yhafsteinsdottir@deloitte.is> Co-authored-by: karenbjorg <khalldorsdottir@deloitte.is> Co-authored-by: andes-it <builders@andes.is> * [TS-889] fix validation for currency (#15803) * if selected employment income and register uneven income, changing to other type of income then months still showed * foreign income per year where not validated * chore: nx format:write update dirty files * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Fixed typo in dataProviders externalDataId * Memoize the rows array to improve performance * Improve useEffect dependency array for better performance. * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * use Int instead of Number for number decorator * remove commented out code and nullable (#15812) * feat(income-plan): income plan conditions (#15820) * call income plan conditions api * Add incomePlanConditions to getApplicationExternalData * Add AlertMessage when no available prerequisites for temporary calculation * change income year * Update dataSchema * Update sendApplication and temporary calculation query input * Update unsetIncomePlan template action and added unit test --------- Co-authored-by: karenbjorg <khalldorsdottir@deloitte.is> * fix(table-repeater): move Item component and remove FC (#15830) * move Item component and remove FC * remove * move Item component * add variables to useEffect dependency array * add contentful id for income plan --------- Co-authored-by: ylfahfa <yhafsteinsdottir@deloitte.is> Co-authored-by: Þorkell Máni Þorkelsson <mani@hugsmidjan.is> Co-authored-by: Þorkell Máni Þorkelsson <wowthorkell@gmail.com> Co-authored-by: ori.jonab <Jon.Arnar.Briem@origo.is> Co-authored-by: andes-it <builders@andes.is> Co-authored-by: Ylfa <55542991+ylfahfa@users.noreply.github.com> Co-authored-by: veronikasif <54938148+veronikasif@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Veronika Sif <veronikasif@hotmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* set up payment plan template * change application name to income plan * add instructions page * implement conclusion screen * Change some texts after review * feat(tr): income plan table (#15340) * fix:add scopes * fix: use type * chore: add to codeowners * fix: codewners * WIP table * feat: update client * fix: handle 404 * fix: write applciation * Seeder file for adding scopes to @island.is/clients/api * chore: nx format:write update dirty files * use application and active field for options in table repeater, populate categories and types in income plan with info from TR, add readonly for fields in table repeater * get currencies from TR and populate dropdown, format input fields that display something regarding income, call withholding tax api from TR and implement some rules when adding income to the income plan * WIP call withholdind income plan api from TR * validation when adding income, wip tooltip on fields in table repeater, format number showed in income table * mock withholding tax and populate table, add readonly to table fields, change tooltip for checkbox and format * add review screen --------- Co-authored-by: Þorkell Máni Þorkelsson <mani@hugsmidjan.is> Co-authored-by: Þorkell Máni Þorkelsson <wowthorkell@gmail.com> Co-authored-by: ori.jonab <Jon.Arnar.Briem@origo.is> Co-authored-by: andes-it <builders@andes.is> * remove fake form steppers and call latest income plan * foreign income + populate table with latest income plan * format * add history logs and corresponding messages * feat(income-plan): text changes (#15636) * text changes * format * eligible and update after withholding tax and latest income plan outputs was changed * [TS-839] Calculate income per year (#15682) * update read me and add flow chart (#15669) * feat(income-plan): make more application card texts editable (#15754) * text changes * format * make open application button texts editable * format * chore: nx format:write update dirty files --------- Co-authored-by: andes-it <builders@andes.is> * [TS-848] Jafnar tekjur á mánuði (#15733) * [TS-849] uneven income (#15701) * feat(income-plan): send income plan (#15777) * WIP send income plan to TR * send income plan * remove * update eligible * default IKR * ts-853 change bottom button link * clean up * feat(income-plan): Add unit tests (#15778) * add unit tests for state transitions * add unit tests for utils * format * chore: nx format:write update dirty files --------- Co-authored-by: andes-it <builders@andes.is> * [TS-847] start application at the first page when table has been filled (#15793) * add review and complete state to income plan + feature flag * validation was triggered * remove mock data * clean * feat(income-plan): Temporary calculation table (#15642) * set up temporary calculation page and data * add print screen custom component and messages * fix input and add to temporary calculation screen * [TS-823] temporary calculation plan page * Add validation to incomePlanTable - nonempty * Fixed query input * Added AlertMessage when no payments * Update temporary calculation query input * chore: nx format:write update dirty files --------- Co-authored-by: ylfahfa <yhafsteinsdottir@deloitte.is> Co-authored-by: karenbjorg <khalldorsdottir@deloitte.is> Co-authored-by: andes-it <builders@andes.is> * [TS-889] fix validation for currency (#15803) * if selected employment income and register uneven income, changing to other type of income then months still showed * foreign income per year where not validated * chore: nx format:write update dirty files * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Fixed typo in dataProviders externalDataId * Memoize the rows array to improve performance * Improve useEffect dependency array for better performance. * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update libs/application/templates/social-insurance-administration/income-plan/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * use Int instead of Number for number decorator * remove commented out code and nullable (#15812) * feat(income-plan): income plan conditions (#15820) * call income plan conditions api * Add incomePlanConditions to getApplicationExternalData * Add AlertMessage when no available prerequisites for temporary calculation * change income year * Update dataSchema * Update sendApplication and temporary calculation query input * Update unsetIncomePlan template action and added unit test --------- Co-authored-by: karenbjorg <khalldorsdottir@deloitte.is> * fix(table-repeater): move Item component and remove FC (#15830) * move Item component and remove FC * remove * move Item component * add variables to useEffect dependency array * add the year for which TR is currently accepting income plans * different description if applicant has accepted income plan * simplify --------- Co-authored-by: ylfahfa <yhafsteinsdottir@deloitte.is> Co-authored-by: Þorkell Máni Þorkelsson <mani@hugsmidjan.is> Co-authored-by: Þorkell Máni Þorkelsson <wowthorkell@gmail.com> Co-authored-by: ori.jonab <Jon.Arnar.Briem@origo.is> Co-authored-by: andes-it <builders@andes.is> Co-authored-by: Ylfa <55542991+ylfahfa@users.noreply.github.com> Co-authored-by: veronikasif <54938148+veronikasif@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Veronika Sif <veronikasif@hotmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

ylfahfa and others added 4 commits July 28, 2024 15:32

set up temporary calculation page and data

a46015b

add print screen custom component and messages

ebdde78

fix input and add to temporary calculation screen

f201bc7

[TS-823] temporary calculation plan page

b89ed2f

veronikasif requested review from a team as code owners August 13, 2024 11:30

veronikasif added 2 commits August 13, 2024 11:34

Add validation to incomePlanTable - nonempty

ca2c43b

Merge branch 'feat/income-plan' into feat/temporary-calculation-table

199132c

karenbjorg and others added 2 commits August 14, 2024 13:19

merge income-plan

5aa81ae

Fixed query input

c8974f5

veronikasif marked this pull request as draft August 14, 2024 17:05

veronikasif added 2 commits August 15, 2024 14:53

Merge branch 'feat/income-plan' into feat/temporary-calculation-table

3c7b064

Added AlertMessage when no payments

cbd4fe1

veronikasif marked this pull request as ready for review August 15, 2024 15:33

veronikasif added 3 commits August 27, 2024 12:00

Update temporary calculation query input

3507a06

Fixed merge conflicts

5c42af9

Fixed merge conflict

bf0bef5

ylfahfa approved these changes Aug 28, 2024

View reviewed changes

andes-it and others added 3 commits August 28, 2024 13:16

chore: nx format:write update dirty files

104d4be

Merge branch 'feat/income-plan' into feat/temporary-calculation-table

abf0c2b

Merge branch 'feat/temporary-calculation-table' of https://github.com…

6422322

…/island-is/island.is into feat/temporary-calculation-table

veronikasif merged commit 7ea82f7 into feat/income-plan Aug 28, 2024
15 checks passed

veronikasif deleted the feat/temporary-calculation-table branch August 28, 2024 13:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(income-plan): Temporary calculation table #15642

feat(income-plan): Temporary calculation table #15642

veronikasif commented Aug 13, 2024

coderabbitai bot commented Aug 13, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

Documentation and Community

datadog-island-is bot commented Aug 13, 2024

codecov bot commented Aug 13, 2024 •

edited

Loading

ylfahfa left a comment

feat(income-plan): Temporary calculation table #15642

feat(income-plan): Temporary calculation table #15642

Conversation

veronikasif commented Aug 13, 2024

What

Why

Screenshots / Gifs

Checklist:

coderabbitai bot commented Aug 13, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

Documentation and Community

datadog-island-is bot commented Aug 13, 2024

Datadog Report

🔻 Code Coverage Decreases vs Default Branch (20)

codecov bot commented Aug 13, 2024 • edited Loading

Codecov Report

ylfahfa left a comment

Choose a reason for hiding this comment

coderabbitai bot commented Aug 13, 2024 •

edited

Loading

codecov bot commented Aug 13, 2024 •

edited

Loading