feat(assets): Bulk mileage registration #15774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes involve significant restructuring within the vehicle domain of the API. Key modifications include the consolidation of exports in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Datadog ReportAll test runs ✅ 5 Total Test Services: 0 Failed, 4 Passed Test Services
🔻 Code Coverage Decreases vs Default Branch (1)
|
thorkellmani
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15774 +/- ##
==========================================
- Coverage 36.70% 36.70% -0.01%
==========================================
Files 6776 6778 +2
Lines 139592 139601 +9
Branches 39685 39687 +2
==========================================
Hits 51243 51243
- Misses 88349 88358 +9 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…y' into feat/bulk-second-try
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
thordurhhh
reviewed
Sep 27, 2024
libs/api/domains/vehicles/src/lib/resolvers/vehicleV3.resolver.ts
Outdated
Show resolved
Hide resolved
thordurhhh
reviewed
Sep 27, 2024
libs/service-portal/assets/src/screens/VehicleBulkMileageUpload/VehicleBulkMileageUpload.tsx
Outdated
Show resolved
Hide resolved
thordurhhh
reviewed
Sep 27, 2024
libs/service-portal/assets/src/screens/VehicleBulkMileageUpload/VehicleBulkMileageUpload.tsx
Outdated
Show resolved
Hide resolved
|
@coderabbitai review pls |
|
Tip For best results, initiate chat on the files or code changes. I've reviewed your changes for the bulk mileage registration feature. Here are some observations:
Overall, this is a valuable feature addition that will greatly benefit users managing multiple vehicles. Great work! |
disaerna
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (14)
- libs/api/domains/vehicles/src/lib/resolvers/bulkMileage.resolver.ts (1 hunks)
- libs/api/domains/vehicles/src/lib/resolvers/mileage.resolver.ts (2 hunks)
- libs/api/domains/vehicles/src/lib/resolvers/vehicleV3.resolver.ts (1 hunks)
- libs/api/domains/vehicles/src/lib/resolvers/vehicles.resolver.ts (1 hunks)
- libs/api/domains/vehicles/src/lib/services/bulkMileage.service.ts (1 hunks)
- libs/island-ui/core/src/lib/IconRC/icons/Upload.tsx (1 hunks)
- libs/island-ui/core/src/lib/IconRC/icons/UploadOutline.tsx (1 hunks)
- libs/service-portal/assets/src/lib/messages.ts (3 hunks)
- libs/service-portal/assets/src/screens/VehicleBulkMileage/VehicleBulkMileage.tsx (1 hunks)
- libs/service-portal/assets/src/screens/VehicleBulkMileage/VehicleBulkMileageFileDownloader.tsx (1 hunks)
- libs/service-portal/assets/src/screens/VehicleBulkMileage/VehicleBulkMileageRow.tsx (1 hunks)
- libs/service-portal/assets/src/screens/VehicleBulkMileage/VehicleBulkMileageSaveButton.tsx (1 hunks)
- libs/service-portal/assets/src/screens/VehicleBulkMileage/types.ts (1 hunks)
- libs/service-portal/assets/src/screens/VehicleBulkMileageUpload/VehicleBulkMileageUpload.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (13)
- libs/api/domains/vehicles/src/lib/resolvers/bulkMileage.resolver.ts
- libs/api/domains/vehicles/src/lib/resolvers/mileage.resolver.ts
- libs/api/domains/vehicles/src/lib/resolvers/vehicleV3.resolver.ts
- libs/api/domains/vehicles/src/lib/resolvers/vehicles.resolver.ts
- libs/api/domains/vehicles/src/lib/services/bulkMileage.service.ts
- libs/island-ui/core/src/lib/IconRC/icons/Upload.tsx
- libs/island-ui/core/src/lib/IconRC/icons/UploadOutline.tsx
- libs/service-portal/assets/src/screens/VehicleBulkMileage/VehicleBulkMileage.tsx
- libs/service-portal/assets/src/screens/VehicleBulkMileage/VehicleBulkMileageFileDownloader.tsx
- libs/service-portal/assets/src/screens/VehicleBulkMileage/VehicleBulkMileageRow.tsx
- libs/service-portal/assets/src/screens/VehicleBulkMileage/VehicleBulkMileageSaveButton.tsx
- libs/service-portal/assets/src/screens/VehicleBulkMileage/types.ts
- libs/service-portal/assets/src/screens/VehicleBulkMileageUpload/VehicleBulkMileageUpload.tsx
🧰 Additional context used
📓 Path-based instructions (1)
libs/service-portal/assets/src/lib/messages.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
🔇 Additional comments (4)
libs/service-portal/assets/src/lib/messages.ts (4)
286-289: New message 'lastRegistration' added correctly.The message
lastRegistrationhas been added with the appropriateidanddefaultMessage.
398-401: New message 'registration' added correctly.The message
registrationhas been added with the appropriateidanddefaultMessage.
402-405: New message 'annualUsage' added correctly.The message
annualUsagehas been added with the appropriateidanddefaultMessage.
895-1051: Bulk mileage messages added correctly.The bulk mileage registration messages have been added with consistent naming conventions and appropriate
ids anddefaultMessages. This enhances localization support for the new feature.
|
Removed |
thoreyjona
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Vehicle bulk mileage frontend * feat: omg it works * chore: remove logs * chore: nx format:write update dirty files * fix: more messsages * feat: bad csv parser * fix: failure calblack * feat: refactor logic * chore: nx format:write update dirty files * feat: better org * chore: update config * feat: update client * feat: update with mutation * feat: organize domain and add methods * feat: update domain * fix: better csv parsing * chore: label * chore: nx format:write update dirty files * feat: some ui * chore: nx format:write update dirty files * feat/clearer ui * chore: empty screen * fix: remove buttons * fix: expand callbacks * fix: linting * fix: expand lower * chore: remove console * chore: localize messages * chore: imports * fix: add logos * fix: parsing * fix: reveiw comments * chore: nx format:write update dirty files * fix: more review fixes * chore: review comment v3 * chore: fix func name * chore: review2 gp * chore: add error message * fix:nullechck * fix:review --------- Co-authored-by: Þórður Hafliðason <tolleinn@gmail.com> Co-authored-by: andes-it <builders@andes.is> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
thorkellmani
added a commit
that referenced
this pull request
Oct 3, 2024
* Vehicle bulk mileage frontend * feat: omg it works * chore: remove logs * chore: nx format:write update dirty files * fix: more messsages * feat: bad csv parser * fix: failure calblack * feat: refactor logic * chore: nx format:write update dirty files * feat: better org * chore: update config * feat: update client * feat: update with mutation * feat: organize domain and add methods * feat: update domain * fix: better csv parsing * chore: label * chore: nx format:write update dirty files * feat: some ui * chore: nx format:write update dirty files * feat/clearer ui * chore: empty screen * fix: remove buttons * fix: expand callbacks * fix: linting * fix: expand lower * chore: remove console * chore: localize messages * chore: imports * fix: add logos * fix: parsing * fix: reveiw comments * chore: nx format:write update dirty files * fix: more review fixes * chore: review comment v3 * chore: fix func name * chore: review2 gp * chore: add error message * fix:nullechck * fix:review --------- Co-authored-by: Þórður Hafliðason <tolleinn@gmail.com> Co-authored-by: andes-it <builders@andes.is> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
*Owners of multiple vehicles should be able to register mileages in bulk
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes
Documentation