fix(skilavottord): Check current owner on deregistration #14763
Conversation
WalkthroughThe recent update involves enhancements in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- apps/skilavottord/ws/src/app/modules/recyclingRequest/recyclingRequest.service.ts (1 hunks)
- apps/skilavottord/ws/src/app/services/icelandicTransportAuthority.services.ts (4 hunks)
Files not reviewed due to errors (1)
- apps/skilavottord/ws/src/app/services/icelandicTransportAuthority.services.ts (no review received)
Files skipped from review due to trivial changes (1)
- apps/skilavottord/ws/src/app/modules/recyclingRequest/recyclingRequest.service.ts
Additional Context Used
Path-based Instructions (1)
apps/skilavottord/ws/src/app/services/icelandicTransportAuthority.services.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14763 +/- ##
==========================================
- Coverage 37.08% 37.07% -0.01%
==========================================
Files 6306 6256 -50
Lines 127980 128475 +495
Branches 36588 36940 +352
==========================================
+ Hits 47458 47629 +171
- Misses 80522 80846 +324 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 295 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 4 Total Test Services: 0 Failed, 4 Passed Test Services
🔻 Code Coverage Decreases vs Default Branch (1)
|
apps/skilavottord/ws/src/app/services/icelandicTransportAuthority.services.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- apps/skilavottord/ws/src/app/services/icelandicTransportAuthority.services.ts (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- apps/skilavottord/ws/src/app/services/icelandicTransportAuthority.services.ts
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
apps/skilavottord/ws/src/app/modules/vehicle/vehicle.service.ts (1)
88-92: Add more detailed logging for owner change.Consider enhancing the logging statement to include both the old and new owner's national ID for better traceability and auditing purposes. This could be particularly useful in debugging or tracking changes over time.
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- apps/skilavottord/ws/src/app/modules/vehicle/vehicle.service.ts (1 hunks)
Additional Context Used
Path-based Instructions (1)
apps/skilavottord/ws/src/app/modules/vehicle/vehicle.service.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
* TRS-17 Add custom to allowedDelegations * TRS-12 - Fix after review * TRS-12 - Added logger when changing owner --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
...
TRS-12
What
Check if current owner is correctly registered in the Skilavottord DB when deregistering the vehicle
Why
Specify why you need to achieve this
Checklist:
Summary by CodeRabbit