Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients-driving-license-book): Student overview update #11857

Merged
merged 33 commits into from
Aug 22, 2023

Conversation

kksteini
Copy link
Member

@kksteini kksteini commented Aug 17, 2023

What

Updated client config, types and graphql to support status/statusName from the driving-license-book client.

Regarding the client config there is this issue: #11858

Why

Driving instructors want to be aware of driving school status when viewing a student.

Screenshots / Gifs

image

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

@kksteini kksteini changed the title Clients driving license book/student overview update feat(clients-driving-license-book): Student overview update Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #11857 (ac22bae) into main (1b94574) will decrease coverage by 0.08%.
The diff coverage is 71.42%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11857      +/-   ##
==========================================
- Coverage   38.04%   37.96%   -0.08%     
==========================================
  Files        5166     5166              
  Lines       97826    98125     +299     
  Branches    24992    25118     +126     
==========================================
+ Hits        37218    37255      +37     
- Misses      60608    60870     +262     
Flag Coverage Δ
air-discount-scheme-backend 56.62% <ø> (ø)
air-discount-scheme-web 0.00% <ø> (ø)
api 4.07% <ø> (ø)
api-domains-air-discount-scheme 34.72% <ø> (ø)
api-domains-assets 26.71% <ø> (ø)
api-domains-auth-admin 54.59% <ø> (ø)
api-domains-communications 40.76% <ø> (ø)
api-domains-driving-license 45.10% <ø> (ø)
api-domains-education 21.01% <ø> (ø)
api-domains-payment-schedule 39.11% <ø> (ø)
application-api-files 52.14% <ø> (ø)
application-core 72.81% <ø> (ø)
application-system-api 42.77% <71.42%> (-0.01%) ⬇️
application-templates-accident-notification 19.76% <ø> (ø)
application-templates-driving-license 14.82% <ø> (ø)
application-types 8.97% <ø> (ø)
application-ui-components 1.63% <ø> (ø)
application-ui-shell 23.80% <ø> (ø)
clients-charge-fjs-v2 34.90% <ø> (ø)
clients-driving-license 38.45% <ø> (ø)
clients-driving-license-book 40.57% <0.00%> (-0.08%) ⬇️
clients-regulations 41.38% <ø> (ø)
clients-rsk-company-registry 29.29% <ø> (ø)
clients-rsk-personal-tax-return 38.00% <ø> (ø)
clients-syslumenn 50.25% <ø> (ø)
cms-translations 39.51% <ø> (ø)
download-service 44.95% <ø> (ø)
financial-aid-backend 57.01% <ø> (ø)
nest-config 76.12% <ø> (ø)
nest-feature-flags 47.68% <ø> (-0.73%) ⬇️
portals-admin-regulations-admin 2.14% <ø> (ø)
portals-core 17.20% <ø> (ø)
service-portal-core 10.78% <ø> (ø)
service-portal-health 0.80% <ø> (ø)
service-portal-information 13.90% <ø> (ø)
services-auth-admin-api 50.69% <ø> (ø)
services-auth-delegation-api 58.85% <ø> (-0.02%) ⬇️
services-auth-ids-api 56.22% <ø> (+0.05%) ⬆️
services-auth-personal-representative 47.15% <ø> (-0.02%) ⬇️
services-auth-personal-representative-public 45.33% <ø> (ø)
services-auth-public-api 51.69% <ø> (ø)
services-endorsements-api 55.91% <ø> (ø)
services-sessions 63.64% <ø> (+0.10%) ⬆️
services-user-notification 25.94% <ø> (ø)
web 1.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...-license-book/src/lib/drivingLicenseBook.module.ts 100.00% <ø> (ø)
...icense-book/src/lib/drivingLicenseBook.resolver.ts 50.00% <ø> (ø)
...license-book/src/lib/drivingLicenseBook.service.ts 12.76% <ø> (ø)
...src/lib/dto/createDrivingSchoolTestResult.input.ts 100.00% <ø> (ø)
.../src/lib/dto/createPracticalDrivingLesson.input.ts 100.00% <ø> (ø)
.../src/lib/dto/deletePracticalDrivingLesson.input.ts 100.00% <ø> (ø)
...ok/src/lib/dto/getPracticalDrivingLessons.input.ts 100.00% <ø> (ø)
.../driving-license-book/src/lib/dto/student.input.ts 100.00% <ø> (ø)
...driving-license-book/src/lib/dto/students.input.ts 100.00% <ø> (ø)
.../src/lib/dto/updatePracticalDrivingLesson.input.ts 100.00% <ø> (ø)
... and 17 more

... and 36 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b94574...ac22bae. Read the comment docs.

@kksteini kksteini marked this pull request as ready for review August 17, 2023 11:06
@kksteini kksteini requested a review from a team as a code owner August 17, 2023 11:06
@kksteini kksteini added the automerge Merge this PR as soon as all checks pass label Aug 17, 2023
@kksteini kksteini closed this Aug 17, 2023
@kksteini kksteini reopened this Aug 17, 2023
@busla busla requested a review from a team as a code owner August 18, 2023 14:27
@busla busla added the skip-nx-cache Skip NX's cache in a pull request label Aug 18, 2023
@busla busla force-pushed the clients-driving-license-book/student-overview-update branch from ecca663 to 4c0b304 Compare August 18, 2023 14:52
Copy link
Member

@AndesKrrrrrrrrrrr AndesKrrrrrrrrrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DevOps files LGTM

@kksteini kksteini removed the automerge Merge this PR as soon as all checks pass label Aug 22, 2023
@busla busla removed skip-nx-cache Skip NX's cache in a pull request nx-verbose labels Aug 22, 2023
@kksteini kksteini added the automerge Merge this PR as soon as all checks pass label Aug 22, 2023
@kodiakhq kodiakhq bot merged commit eb59139 into main Aug 22, 2023
132 checks passed
@kodiakhq kodiakhq bot deleted the clients-driving-license-book/student-overview-update branch August 22, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants