Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openapi Generator Fails on allOf #11858

Closed
kksteini opened this issue Aug 17, 2023 · 4 comments
Closed

Openapi Generator Fails on allOf #11858

kksteini opened this issue Aug 17, 2023 · 4 comments
Labels
stale Issue or pull request is stale

Comments

@kksteini
Copy link
Member

kksteini commented Aug 17, 2023

What?

When updating to the latest driving-license-book client we get curious messages when running the external-openapi-generator.
The generation does not succeed fully and a lot of types/models are replaced by unknownBaseType which then results in our code not compiling due to typescript errors.

To reproduce

Have XROAD proxy running.

  • yarn nx run clients-driving-license-book:update-openapi-document
  • yarn nx run clients-driving-license-book:schemas/external-openapi-generator

The clientConfig.json generated in the first step is a valid openapi format when passed through a validator.

Possibly related issues

I've found these issues:

Solutions

  • In a recent PR, feat(clients-driving-license-book): Student overview update #11857, I had to manually edit the allOf blocks in the clientConfig since every one of them only had a single reference entry and they could be omitted. Not a great solution but possible in very certain situations. Advantages: not costly in terms of work. Disadvantages are that this doesn't fix anything, really.

  • Update the openapi generator. Haven't looked deeply into this, but if we go from a major version of 1 to 2, then things start breaking pretty quickly. I tried these following versions as an update but they still had the errors present: [1.0.18-5.0.0-beta2 and 1.0.18-4.3.1]

@andes-it
Copy link
Member

This issue is stale because it has been open for 5 days with no activity. Remove stale label or this will be closed in 1 day.

@andes-it andes-it added the stale Issue or pull request is stale label Oct 12, 2023
@andes-it
Copy link
Member

This issue was closed because no activity was received 1 day after it was marked as stale.

@andes-it andes-it closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2023
@kksteini kksteini reopened this Apr 24, 2024
@andes-it andes-it removed the stale Issue or pull request is stale label Apr 25, 2024
@andes-it
Copy link
Member

This issue's been twiddling its thumbs for 5 days. Daydreaming, perhaps? Best do something or it's curtains in 1 day. Nudge off the stale label to give it another go.

@andes-it andes-it added the stale Issue or pull request is stale label Apr 30, 2024
@andes-it
Copy link
Member

andes-it commented May 1, 2024

This issue's shut up shop. Gave it a day post-stale, then decided, "Enough's enough!"

@andes-it andes-it closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue or pull request is stale
Projects
None yet
Development

No branches or pull requests

2 participants