Remove legacy sync path #19714
Merged
Remove legacy sync path #19714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
reviewed
Jan 15, 2025
This removes all the needless blocking operations that were occurring on hip. Removal should boost speed and allow multi device parallelism.
rsuderman
force-pushed
the
kill_legacy_path
branch
from
3ccedad to
c87a44c
Compare
ScottTodd
reviewed
Jan 15, 2025
| struct ROCMOptions { | ||
| std::string target = ""; | ||
| std::string targetFeatures = ""; | ||
| std::string bitcodeDirectory = getDefaultBitcodeDirectory(); | ||
| int wavesPerEu = 0; | ||
| std::string enableROCMUkernels = "none"; | ||
| bool legacySync = true; |
There was a problem hiding this comment.
Digging through history:
- Removing the use of the legacy_sync hack from all but ROCM. #16493 removed legacy_sync from all but ROCM, since "The ROCM HAL does not support command buffers at all"
- At the time, we still had hal/rocm and experimental/hip
- [HIP] Adds graph command buffer & descriptor set and pipeline layout #15910 added graph command buffers to experimental/hip
- [hip] Move into hal/drivers and build by default #16706 promoted experimental/hip to hal/drivers/
- We later deleted hal/rocm
@benvanik @nithinsubbiah does that sound right?
So I think we're ready for this now? All tests seem to be passing.
|
So my main comment here is that the hip backend still "technically" supports inline execution. |
benvanik
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all the needless blocking operations that were occurring on hip. Removal should boost speed and allow multi device parallelism.