Removing the use of the legacy_sync hack from all but ROCM. #16493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ROCM HAL does not support command buffers at all and thus only executes with legacy_sync set. No other HAL requires it. This should be a no-op for Vulkan/WebGPU, which are synchronous but handle that internally during submission. Only the ROCM HAL is relying on the compiler to insert the waits and change command buffers to allow-inline-execution. This is in preparation for removing the FixupLegacySyncPass.
benvanik
added
compiler/dialects
benvanik
requested review from
hanhanW,
MaheshRavishankar and
ScottTodd
as code owners
ScottTodd
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ROCM HAL does not support command buffers at all and thus only executes with legacy_sync set. No other HAL requires it.
This should be a no-op for Vulkan/WebGPU, which are synchronous but handle that internally during submission. Only the ROCM HAL is relying on the compiler to insert the waits and change command buffers to allow-inline-execution.
This is in preparation for removing the FixupLegacySyncPass.