Exclude tests failing on Windows in ctest_all.sh. #11119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
added
infrastructure
pzread
approved these changes
Nov 11, 2022
GMNGeoffrey
approved these changes
Nov 11, 2022
| @@ -65,6 +65,26 @@ fi | |||
| IFS=',' read -ra extra_label_exclude_args <<< "${IREE_EXTRA_COMMA_SEPARATED_CTEST_LABELS_TO_EXCLUDE:-}" | |||
| label_exclude_args+=(${extra_label_exclude_args[@]}) | |||
|
|
|||
| # Some tests are just failing on some platforms and this filtering lets us | |||
There was a problem hiding this comment.
Oh because it's some subset of the tests in the macro, sigh. I think when creating those I considered adding fields for overriding individual tests, but it seemed more straightforward for people to add individual rules. Anyways, let's not touch that right now
There was a problem hiding this comment.
Yeah... I was thinking about adding something below ### BAZEL_TO_CMAKE_PRESERVES_ALL_CONTENT_BELOW_THIS_LINE ### that would disable the specific test (somehow), but this was easier :/
This was referenced Dec 9, 2022
This was referenced Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #11009 (see other implementation ideas for filtering at #11009 (comment))