Set error message for where to report bugs #11602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpienaar
requested review from
benvanik,
GMNGeoffrey and
stellaraccident
as code owners
|
uh, that's a lot of commits? 😮 |
|
(otherwise LGTM - just need to clean up whatever happened in git - thanks for doing this!) |
I don't know why I keep doing this ... I git pull main && git branch && git checkout && git commit && gh pr create ... I should just explicitly have a git fetch gh && git rebase gh/main in there too. |
Avoids recommending filing bugs with LLVM project for IREE project tooling.
|
if you pull main while on main then it should rebase for you - maybe you're issuing your git pull main while on another branch? |
benvanik
approved these changes
Dec 19, 2022
benvanik
reviewed
Dec 19, 2022
tools/iree-opt-main.cc
Outdated
|
|
||
| int main(int argc, char **argv) { return ireeOptRunMain(argc, argv); } | ||
| int main(int argc, char **argv) { | ||
| llvm::setBugReportMsg( |
There was a problem hiding this comment.
this calls the method in IREEOptToolEntryPoint.cpp so it shouldn't be needed here
This was referenced Dec 30, 2022
pzread
pushed a commit
to pzread/iree
that referenced
this pull request
Jan 4, 2023
This reverts commit 17ec7ab.
pzread
pushed a commit
to pzread/iree
that referenced
this pull request
Jan 11, 2023
This reverts commit 17ec7ab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids recommending filing bugs with LLVM project for IREE project tooling.