Assorted fixes for tests on Windows. #11079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
added
infrastructure
GMNGeoffrey
approved these changes
Nov 8, 2022
| # Extend the PYTHONPATH environment variable with _RULE_PACKAGE_DIRS. | ||
| list(APPEND _RULE_PACKAGE_DIRS "$ENV{PYTHONPATH}") | ||
| if(${CMAKE_SYSTEM_NAME} STREQUAL "Windows") | ||
| # Windows uses semi-colon delimiters, but so does CMake, so escape them. |
There was a problem hiding this comment.
😢 Luckily this doesn't get passed around too much afterwards. Is it really necessary though? I thought when you expanded a list within quotes you got the string version anyway. I'm guessing you determined that it is necessary, but I'm slightly surprised
There was a problem hiding this comment.
Yeah, I tried a few variations on this and either got only the first element of the list (i.e. runtime) or no delimiter at all (i.e. runtimecompiler).
This was referenced Dec 9, 2022
This was referenced Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #11009 (see some test runs of a
build_test_all_windowsCI job on #11050)simple_embedding_vulkan_testas using Vulkan, so it can be filtered