This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
chore: update dependencies #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=======================================
Coverage 99.36% 99.36%
=======================================
Files 19 19
Lines 791 791
=======================================
Hits 786 786
Misses 5 5
Continue to review full report at Codecov.
|
ethereumjs libraries are using TypeScript which create named and default exports we have to use now
|
Thanks @rvagg. I just rebased it an updated it to the very latest deps. Hence I dare to merge it without any further review. |
|
I actually didn't update to the latest deps (I forgot to commit that). But that isn't really an issue as all of the updates are in range. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethereumjs libraries are using TypeScript which create named and default exports we have to use now
I'm mainly trying to get past the keccak compile errors but ethereumjs-block and merkle-patricia-tree need to update their ethereumjs-util dependency, they're a bit stalled on their interlocked dependencies and their big typescript migration though ethereumjs/ethereumjs-block#74
Here's the problem with this PR though - it doesn't pass on my mac. I get a
uv_close()assert deep in the guts of Node during test run, somewhat at random but regular enough to not be able to fully pass through Browser + WebWorker tests most runs without crashing (sometimes it gets through, green). I can't work out whether it's an aegir, karma, node, addon (fsevents possibly since it messes around down at that level on macos) or even Chrome version problem. I don't really see why it would be related to the dependency updates so would appreciate someone trying to replicate the problems.