-
Notifications
You must be signed in to change notification settings - Fork 49
Conversation
Hmm, linting was passing on my local machine, strange. 😕 Travis is not making itself friends these days, grmbl. |
I'm slightly hesitant about releasing this version before it gets integrated into the vm. Otherwise, if a user installs |
I think you have an outdated |
Hi Patricio, this comment is actually giving me some headaches. Can we for now just stick to the a bit rough current procedure and just do the release in cases like this? We just don't have the capacity right now to switch to a more sophisticated model with doing beta releases all over the front and then synchronize releases at some point in time. Actually we already had this situation reoccuring on various fronts (e.g. along with the major tx library update). As I said we can nevertheless improve on this by better document. |
601d80f
to
4374c7c
Compare
@alcuadrado Ok, was again the |
Just for reference, this conversation is also happening here: ethereumjs/ethereumjs-monorepo#571 |
Hm, it seems we're in a situation. We need an On the other hand, I think rough consensus was to have Istanbul support in VM first as v4 and only then integrate this new I guess the only option is to integrate the new Block in VM and release that as v5? What do you guys think? Alternatively we could also backport #76 to v2.2 |
@s1na Hmm, just had a look. Since this release would bring significant updates beneath just the TypeScript integration, e.g. also version updates on |
@s1na On the other hand I am undecided though, since backporting #76 would be a very much simple fix. If this already does the thing maybe it is really the safer option for now. On writing this I have more and more the tendency to stick with that, seems there is already still enough to do on the VM without major dependency version updates and additional integration work. |
@s1na Could you describe the technical steps needed for a backport release? I am bit unsure about this since I never practically executed such a case in the current branching model. Would we branch off from the latest release commit and do these changes again? Hmm, maybe just give me a short step-by-step list please. 🙂 |
@holgerd77 Here's how I think we can handle the backport:
I can start by preparing the branch, but maybe we can wait before we do the release until we hear from @alcuadrado. |
I think I prefer the backporting alternative, as it would mean less integration work for the VM consumers. Having full Instanbul support in Ganache is pretty important, and this is the easiest path for them to achieve that. If we release all the pending breaking changes now, they may not have enough time to integrate them before the actual HF happens. I think the steps proposed by @s1na would work. |
@s1na @alcuadrado Ok, great, then we have a plan here. 🕵️♂️ 😄 |
Closing in favor of ethereumjs/ethereumjs-monorepo#682. |
No description provided.