Move api version check to header #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| return nil, cmds.ClientError(e) | ||
| return nil, nil |
There was a problem hiding this comment.
- why is this no longer an error?
and why nil, instead ofnevermindfunc () {}?
There was a problem hiding this comment.
- api file exists does not necessarily imply daemon exists, e.g. the case when the daemon gets killed.
- because https://github.com/ipfs/go-ipfs/blob/83246d3e2d00e7a30ea7d606df9830198f864c4a/cmd/ipfs/main.go#L324 only checks for nil.
|
tenatively calling this one part of 0.3.10. @rht do you think we can get this in by thursday? |
|
@whyrusleeping if 0.3.10 is very close, we can ship it and do a 0.3.11 for the rest of these things before 0.4.0 |
|
right, very close is feeling like thursday to me, based on past experience. |
|
and i'm gonna nix any 0.3.11, 0.3.10, then 0.4.0. everything else can be rebased. |
rht
force-pushed
the
header-version-check
branch
from
99b9324
to
1d20f24
Compare
|
Sorry, @whyrusleeping just rebased. |
Merged
ghost
added
the
License: MIT Signed-off-by: rht <rhtbot@gmail.com>
License: MIT Signed-off-by: rht <rhtbot@gmail.com>
whyrusleeping
force-pushed
the
header-version-check
branch
from
1d20f24
to
aabf807
Compare
|
alright, this has been around long enough. merging |
whyrusleeping
added a commit
that referenced
this pull request
Dec 28, 2015
Move api version check to header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2003 but on master.
closes #1990, #2003
Addresses #2003 (comment) by checking if the repo is process-locked.