Move api version check to daemon #2003
Conversation
|
Doesn't solve the closenotify chan problem, however. |
|
Awesome! looks like it breaks tests though |
|
Saw it, possibly because now that the daemon demands the api header. Make it optional? (or make it necessary) |
rht
force-pushed
the
daemon-version-check
branch
2 times, most recently
from
72e090e
to
977aed3
Compare
|
I picked the optional, since it was the default behavior previously. |
License: MIT Signed-off-by: rht <rhtbot@gmail.com>
rht
force-pushed
the
daemon-version-check
branch
from
3e406ee
to
1e95594
Compare
|
Not sure how to fix the pollEndpoint errs. |
|
those errors look like its the daemon failing to start. |
License: MIT Signed-off-by: rht <rhtbot@gmail.com>
|
👍 on this PR. Optional sounds good to me, too. sharness tests still failing. |
|
|
||
| // make sure the api is actually running. | ||
| // this is slow, as it might mean an RTT to a remote server. | ||
| // TODO: optimize some way |
There was a problem hiding this comment.
ok, there's a problem here. part of the goal is to check that the endpoint is available, which may be a case of a stale $repo/api file (eg ipfs daemon, then kill -9 $pid). we could "check" by trying to use it, but im no longer sure how the flow will work here. I recall it being tricky to get right + cover all the bases.
|
(moved to 0.3.11 #2037) |
closes #1990