-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non disposable daemon init/start and attach to running daemons #308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hugomrdias I've changed the target of this branch to PR against my branch. Let's merge both and then merge to master.
@diasdavid this was already rebased with master I would prefer to keep both PR separate. But if you want to merge them, we should rebase yours with master, merge this one with yours, make sure the example work and then merge it back to this one with fast-foward. |
d3640ee
to
db6375f
Compare
#304 has now master rebased onto it. |
Fails a bunch of tests on the browser with the same error:
Tests failing are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs all tests to pass
@hugomrdias wanna make the tests work on the browser as well?
b78d954
to
c97b3a4
Compare
it works now 🔥 🔥 Pls review again. |
CI only has a commitlint error squash will fix that and 2 Windows random errors. |
Co-Authored-By: hugomrdias <mail@hugodias.me>
9fd2dbd
to
f693cd0
Compare
@@ -23,7 +20,7 @@ class FactoryDaemon { | |||
if (options && options.type === 'proc') { | |||
throw new Error('This Factory does not know how to spawn in proc nodes') | |||
} | |||
this.options = Object.assign({}, { type: 'go' }, options) | |||
this.options = Object.assign({ type: 'go' }, options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit: we've required merge-options
above, why not use it here instead of Object.assign
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attaching to running daemons is a great feature, LGTM.
@hugomrdias what's missing for this PR to land? |
@hugomrdias not necessary anymore? |
no 0.47.0 has all this and more |
This PR reworks daemon spawn options and handling of start/init, it also makes sure spawned daemons attach themselves to running daemons on the default/provided repo.
Ref: #304
Fixes #305
Fixes #276