Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: Cannot read property 'id' of null #276

Closed
vaibhav6233m opened this issue Jul 4, 2018 · 2 comments · Fixed by #379
Closed

TypeError: Cannot read property 'id' of null #276

vaibhav6233m opened this issue Jul 4, 2018 · 2 comments · Fixed by #379
Assignees
@hugomrdias
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/in-progress In progress

Comments

@vaibhav6233m
Copy link

I am trying a simple example to spawn IPFS node inside the electron main process.

I am getting this issue if I try to pass custom options inside f.spawn() method.
If I don't pass any options then it starts the node.

See SS:

screenshot from 2018-07-04 15-47-09
screenshot from 2018-07-04 15-47-29

Thanks in advance.
@vaibhav6233m
Copy link
Author

I came to know that if you pass disposable: true then the node starts with the settings provided, but I still need to maintain the custom node repo inside electron app config folder.

@daviddias daviddias added the status/ready Ready to be worked label Aug 25, 2018
@hugomrdias hugomrdias added kind/bug A bug in existing code (including security flaws) help wanted Seeking public contribution on this issue exp/expert Having worked on the specific codebase is important P2 Medium: Good to have, but can wait until someone steps up labels Aug 27, 2018
@daviddias
Copy link
Member

Being fixed at #304.

@hugomrdias hugomrdias mentioned this issue Oct 29, 2018
Closed
@ghost ghost assigned hugomrdias Oct 29, 2018
@ghost ghost added status/in-progress In progress and removed status/ready Ready to be worked labels Oct 29, 2018
hugomrdias added a commit that referenced this issue Sep 17, 2019
@hugomrdias
fix: fix non-disposable and normalise behaviour
f95d011 
closes #305
closes #276
closes #354
closes #330
closes #329
@hugomrdias hugomrdias mentioned this issue Sep 17, 2019
Merged
hugomrdias added a commit that referenced this issue Sep 17, 2019
@hugomrdias
fix: fix non-disposable and normalise behaviour
6be1a2b 
closes #305
closes #276
closes #354
closes #330
closes #329
hugomrdias added a commit that referenced this issue Sep 18, 2019
@hugomrdias
fix: fix non-disposable and normalises behaviour (#379)
b502bd4 
This PR reworks daemon spawn options and handling of start/init, it also makes sure spawned daemons attach themselves to running daemons on the default/provided repo.
Some dependencies were also removed.

closes #305
closes #276
closes #354
closes #330
closes #329
This was referenced Oct 27, 2019
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hugomrdias hugomrdias

Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/in-progress In progress
Projects
None yet
Milestone
No milestone
3 participants
@hugomrdias @daviddias @vaibhav6233m