Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust mac and dmg artifactName #2296

Merged
merged 2 commits into from
Oct 11, 2022
Merged

fix: adjust mac and dmg artifactName #2296

merged 2 commits into from
Oct 11, 2022

Conversation

lidel
Copy link
Member

@lidel lidel commented Oct 10, 2022

This PR aims to close #2291 by changing implicit artifactName to explicit ones in electron-builder.yml, setting different ones for .zip and .dmg mac targets.

We can't remove .zip because of reasons described in #1922 (comment), but we can rename it to something other than -mac.

Old names

IPFS-Desktop-0.24.0.dmg
IPFS-Desktop-0.24.0.dmg.blockmap
IPFS-Desktop-0.24.0-mac.zip
IPFS.Desktop-0.24.0-mac.zip.blockmap

New names

ipfs-desktop-0.24.0-mac.dmg
ipfs-desktop-0.24.0-mac.dmg.blockmap
ipfs-desktop-0.24.0-squirrel.zip
ipfs-desktop-0.24.0-squirrel.zip.blockmap

@lidel lidel requested a review from tinytb October 10, 2022 19:53
@lidel lidel marked this pull request as ready for review October 10, 2022 19:55
@lidel lidel requested a review from a team as a code owner October 10, 2022 19:55
@lidel lidel changed the title fix: adjust mac artifactName fix: adjust mac and dmg artifactName Oct 10, 2022
Copy link

@tinytb tinytb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 🎉

I hope it doesn't break anything... but as I can't think of an easy way to test, I'm okay with trying it, and then fixing if anything goes wrong.

@lidel
Copy link
Member Author

lidel commented Oct 11, 2022

My understanding of the autoupdate process is that the next release will generate artifacts under new name, and the new latest-mac.yml (manifest which is periodically fetched by Electron app) will include new names, so nothing should break.

fyi old latest-mac.yml looked like this:

version: 0.24.0
files:
  - url: IPFS-Desktop-0.24.0-mac.zip
    sha512: 7WdMccRPaRql6nov+ctWBpdV2t4vAEuFYhESia/denudwTnNtu1GoTnMFrl2kmy+CeHNPGzLrFGC5Qjlq7VsgQ==
    size: 125086300
  - url: IPFS-Desktop-0.24.0.dmg
    sha512: ttaNfQ2Os/RFD5I8JHC1VmOpXeIXixBIoE55FXkQsFIML/kEYzBOj4xlOUiTAWzEBqC8QLQ8tqEG5rcf8YtMgw==
    size: 131098113
path: IPFS-Desktop-0.24.0-mac.zip
sha512: 7WdMccRPaRql6nov+ctWBpdV2t4vAEuFYhESia/denudwTnNtu1GoTnMFrl2kmy+CeHNPGzLrFGC5Qjlq7VsgQ==
releaseDate: '2022-10-03T21:14:55.198Z'

@lidel lidel merged commit 3891865 into main Oct 11, 2022
@lidel lidel deleted the fix/mac-artifact-name branch October 11, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Rename IPFS-Desktop-[version]-mac.zip file in Releases?
3 participants