Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename IPFS-Desktop-[version]-mac.zip file in Releases? #2291

Closed
tinytb opened this issue Oct 6, 2022 · 2 comments · Fixed by #2296
Closed

Rename IPFS-Desktop-[version]-mac.zip file in Releases? #2291

tinytb opened this issue Oct 6, 2022 · 2 comments · Fixed by #2296
Labels
effort/hours Estimated to take one or several hours need/analysis Needs further analysis before proceeding P2 Medium: Good to have, but can wait until someone steps up topic/docs Documentation

Comments

@tinytb
Copy link

tinytb commented Oct 6, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

As noted in #1922, the "mac.zip" file is used for autoupdate, but should not be downloaded from the GitHub Releases page for installation.

Currently, each Release includes two files that look Mac-related, e.g.:

  • IPFS-Desktop-0.24.0-mac.zip
  • IPFS-Desktop-0.24.0.dmg

Worse, the dmg file doesn't say mac in it, so users could be confused if they are not aware that dmg files are only used by Macs, and commonly used for Mac software installation.

Describe the solution you'd like

In releases, rename the "mac.zip" file to something that makes it clear that it's not what most users want to download. For example, "IPFS-Desktop-0.24.0-autoupdate-artifact.zip".

Describe alternatives you've considered

Renaming "IPFS-Desktop-0.24.0.dmg" may also help. For example, "IPFS-Desktop-0.24.0-mac.dmg". Some Mac users are accustomed to looking for "mac" to find the installer for their platform.

Another idea is to add a note in each release that explains the purpose of each asset. This would reduce confusion for people looking through the list of 17 assets.
@tinytb tinytb added the need/triage Needs initial labeling and prioritization label Oct 6, 2022
@welcome
Copy link

welcome bot commented Oct 6, 2022

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@SgtPooki SgtPooki added P2 Medium: Good to have, but can wait until someone steps up need/analysis Needs further analysis before proceeding effort/hours Estimated to take one or several hours topic/docs Documentation and removed need/triage Needs initial labeling and prioritization labels Oct 10, 2022
@SgtPooki
Copy link
Member

Triage meeting notes: Need to decide on next action. Can we rename? If not, can we update release description to provide more context for users?

Related:
#1922
https://www.electron.build/configuration/dmg
electron-userland/electron-builder#6496

lidel added a commit that referenced this issue Oct 10, 2022
@lidel
fix: adjust mac artifactName
5bb9980 
Closes #2291
@lidel lidel mentioned this issue Oct 10, 2022
Merged
lidel added a commit that referenced this issue Oct 10, 2022
@lidel
fix: use mac only in .dmg artifacts
0079e60 
Should help with confusion described in #2291
lidel added a commit that referenced this issue Oct 11, 2022
@lidel
fix: adjust mac and dmg artifactName (#2296)
3891865 
* fix: adjust mac artifactName

Closes #2291

* fix: use mac only in .dmg artifacts

Should help with confusion described in #2291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours need/analysis Needs further analysis before proceeding P2 Medium: Good to have, but can wait until someone steps up topic/docs Documentation
Projects
No open projects
IPFS-GUI (PL EngRes)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adjust mac and dmg artifactName ipfs/ipfs-desktop
2 participants
@SgtPooki @tinytb