fix(ci): hanging tests #1106
Merged
fix(ci): hanging tests #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems that since we introduced c8 the tests sometimes hang (they finish correctly, but node process hangs and never exists). This ensures we get failure sooner than after 360m (default on github)
lidel
commented
Nov 24, 2022
Comment on lines
+68
to
+70
| "src": [ | ||
| "add-on/src/" | ||
| ], |
There was a problem hiding this comment.
Perhaps this will fix? seems to speed up c8 for me locally – perhaps it was processing ./ which includes node_modules or 🤷
lidel
force-pushed
the
chore/fail-ci-faster
branch
from
1069622
to
3bb798e
Compare
|
It seems we still have flaky tests: So slow c8 (fixed by this PR?) was not the underlying cause. Probably mocha. See the final fix in #1107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm testtakes ~30s. If it hangs for longer than a minute, it is clearly a bug.This PR ensures we get failure sooner than after 360m (default on github)
Why?
CI hang problem appeared around #1101 – i think it is c8 being very, very slow – note that tests finish correctly, but node process hangs and never exists.