Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): hanging tests #1106

Merged
merged 2 commits into from
Nov 24, 2022
Merged

fix(ci): hanging tests #1106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12dfde5
chore(ci): fail hanging tests faster
lidel Nov 24, 2022
3bb798e
fix(ci): c8 hanging npm test
lidel Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ jobs:

- name: Test
run: npm run ci:test
# tests should finish <30s, if it takes longer its a bug - fail fast
timeout-minutes: 5

- name: Lint
# bundles are too big on Windows and fail addon-lint
Expand Down
165 changes: 55 additions & 110 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@
"preferGlobal": false,
"c8": {
"all": true,
"src": [
"add-on/src/"
],
Comment on lines +68 to +70
Copy link
Member Author

@lidel lidel Nov 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this will fix? seems to speed up c8 for me locally – perhaps it was processing ./ which includes node_modules or 🤷

"reporter": [
"text"
],
Expand Down Expand Up @@ -93,7 +96,7 @@
"json": "11.0.0",
"mem-storage-area": "1.0.3",
"mini-css-extract-plugin": "2.7.0",
"mocha": "9.2.2",
"mocha": "10.1.0",
"npm-run-all": "4.1.5",
"path": "0.12.7",
"raw-loader": "4.0.2",
Expand Down