Stop defaulting to color output on non-TTY #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is arguably a breaking change, but there really is no legitimate case for output like this: https://circleci.com/gh/filecoin-project/lotus/189136 The change as implemented respects any explicit setting the user might have provided, and also keeps coloration in the URL case, in order to minimize the potential fallout
Stebalien
approved these changes
Jul 4, 2021
Actually... I am glad you asked! As written the code would not allow it. With the latest commit you now can: |
|
@magik6k @aschmahmann any objections to this or do I just |
?
Stebalien
reviewed
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is arguably a breaking change, but there really is no legitimate case
for output like this: https://circleci.com/gh/filecoin-project/lotus/189136
The change as implemented respects any explicit setting the user might have
provided, and also keeps coloration in the URL case, in order to minimize
the potential fallout