Enable color by default only if os.Stdout is a TTY #6696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Jul 7, 2021
cli/util/color.go
Outdated
| "github.com/mattn/go-isatty" | ||
| ) | ||
|
|
||
| var DefaultColorUse = isatty.IsTerminal(os.Stdout.Fd()) || isatty.IsCygwinTerminal(os.Stdout.Fd()) |
There was a problem hiding this comment.
Can we also have an env var for this? (LOTUS_COLOR=1, or sth like that, unless there is already a standard env var for that kind of thing)
Just isatty.IsTerminal will return false when running stuff in watch --color .. for example.
There was a problem hiding this comment.
So... we could introduce LOTUS_COLOR=1 OR we could recognize GOLOG_LOG_FMT=color which is a thing from ipfs/go-log
I can go either way, just suggesting an alternative for smaller amount of options to keep track of...
@magik6k say the word
There was a problem hiding this comment.
@Stebalien please be weighing in as well, I surely missed other stuff here too ;)
There was a problem hiding this comment.
@magik6k please be checking 4dd59b566ced
magik6k
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.