Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 2× multisample antialiasing by default #489

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Calinou
Copy link

@Calinou Calinou commented Mar 14, 2021

Follow-up to #487 (can be merged independently from it).

Given the low shader complexity and polygon counts, this should be safe to enable by default, even on integrated graphics.

This change applies to both the OpenGL 1 and OpenGL 2 renderers.

Given the low shader complexity and polygon counts, this should be
safe to enable by default, even on integrated graphics.

This change applies to both the OpenGL 1 and OpenGL 2 renderers.
@ghost
Copy link

ghost commented Mar 16, 2021

Enabling r_ext_multisample in GL2 destroys the sun rays (BUG!). Using only fbo multisampling is enough imo, using both just slows down the renderer.

@zturtleman
Copy link
Member

r_ext_multisample 2 fails to create a window on Linux/X11 using some Intel integrated graphics (Debian 10, Intel(R) Core(TM)2 Duo CPU E8400). ioquake3's window creation should probably try disabling multisample if window creation fails. r_ext_framebuffer_multisample 2 does work however.

----- Client Initialization Complete -----
----- R_Init -----
SDL using driver "x11"
Initializing OpenGL display
Display aspect: 1.778
...setting mode -1: 1280 720
Couldn't get a visual
...WARNING: could not set the given mode (-1)
Initializing OpenGL display
Display aspect: 1.778
...setting mode -1: 1280 720
Couldn't get a visual
...WARNING: could not set the given mode (-1)
Setting r_mode -1 failed, falling back on r_mode 3
Initializing OpenGL display
Display aspect: 1.778
...setting mode 3: 640 480
Couldn't get a visual
...WARNING: could not set the given mode (3)
----- Client Shutdown (Client fatal crashed: GLimp_Init() - could not load OpenGL subsystem) -----
RE_Shutdown( 1 )
Hunk_Clear: reset the hunk ok
-----------------------
GLimp_Init() - could not load OpenGL subsystem

@Calinou
Copy link
Author

Calinou commented Mar 18, 2021

Should we just default r_ext_framebuffer_multisample to 2 to solve this (and keep r_ext_multisample to its current value)? This would effectively enable MSAA only when using the OpenGL 2 renderer, but now that it's the default renderer, this should be fine.

Also, last time I tried, enabling framebuffer MSAA without enabling standard MSAA won't smooth out 3D models drawn on the HUD (such as the player's face). Admittedly, this is a minor issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants