You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added IPv4PoolRef/IPv6PoolRef to both IonosCloudMachine and Network
workflow: IonosCloudMachine controller checks for PoolRefs and creates IPAddressClaims when needed. It then waits for an external controller to create IPAddress objects from the IPAddressClaim. Then it uses the IP from the IPAddress object to create a server via Ionos cloud api.
Special notes for your reviewer:
I did not write tests yet as I am waiting for #137 to be merged and I'd like to get some feedback about this PR first.
I am also unsure where I should put the docs, I did not find anything for the other api stuff beside the api definition itself. Maybe this is already enough?
For the documentation, I'd just write a new markdown file in docs/. Also have you tested your changes? If so, please proceed with e2e tests, as #137 has already been merged
Thank you. This PR will be the next priority after upgrading to 1.8.1.
There were some updates in the e2e framework, which have been addressed in #212 and I would suggest that we first merge the 1.8.1 PR and then have a final update here.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mattes83
requested review from
piepmatz,
lubedacht,
gfariasalves-ionos,
mcbenjemaa,
wikkyk and
jriedel-ionos
as code owners
What is the purpose of this pull request/Why do we need it?
We would like to get IPs from a fixed pool of IPs instead of relying on the DHCP.
Issue #, if available:
#130
Description of changes:
Special notes for your reviewer:
I did not write tests yet as I am waiting for #137 to be merged and I'd like to get some feedback about this PR first.
I am also unsure where I should put the docs, I did not find anything for the other api stuff beside the api definition itself. Maybe this is already enough?
Checklist: